Skip to content

Unrelated changes - Roxygen update#622

Merged
seabbs merged 3 commits intomainfrom
unrelated-changes
Feb 12, 2024
Merged

Unrelated changes - Roxygen update#622
seabbs merged 3 commits intomainfrom
unrelated-changes

Conversation

@nikosbosse
Copy link
Copy Markdown
Collaborator

@nikosbosse nikosbosse commented Feb 8, 2024

Description

This PR commits changes due to an update in roxygen. It does that because I'm a good developer and would never mix unrelated changes into other PRs... 👀

There is another unrelated change to the Readme.md file. This comes from the update to the print method in #592 and the automatic CI update of the readme. It actually uncovers an error that we need to fix, namely score() does not respect previous output from add_coverage(). I opened an issue for this (#623)

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@nikosbosse nikosbosse requested a review from seabbs February 8, 2024 15:36
@nikosbosse nikosbosse closed this Feb 8, 2024
@nikosbosse nikosbosse reopened this Feb 8, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc98c89) 85.88% compared to head (d26f699) 85.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #622   +/-   ##
=======================================
  Coverage   85.88%   85.88%           
=======================================
  Files          21       21           
  Lines        1771     1771           
=======================================
  Hits         1521     1521           
  Misses        250      250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse nikosbosse changed the title Roxygen update Unrelated changes - Roxygen update Feb 8, 2024
Copy link
Copy Markdown
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs merged commit 39c95d4 into main Feb 12, 2024
@seabbs seabbs deleted the unrelated-changes branch February 12, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants