Skip to content

Issue #709: Rename rules to metrics#710

Merged
nikosbosse merged 13 commits intomainfrom
rules-to-metrics
Mar 9, 2024
Merged

Issue #709: Rename rules to metrics#710
nikosbosse merged 13 commits intomainfrom
rules-to-metrics

Conversation

@nikosbosse
Copy link
Copy Markdown
Collaborator

@nikosbosse nikosbosse commented Mar 8, 2024

Description

This PR closes #709.
This PR closes #610

Following the discussion in #610 this PR replaces occurrences of "rules" with "metrics" in the code

(to be precise, I updated the code by searching and replacing

  • rules_ with metrics_
  • _rules with _metrics
  • rules = with metrics =
  • (rules with (metrics)

The PR also updates a few instances in the docs to make it clear that "rules" means "metrics and scoring rules"

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (5db9070) to head (cab02d6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #710   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files          21       21           
  Lines        1632     1632           
=======================================
  Hits         1555     1555           
  Misses         77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse nikosbosse requested a review from seabbs March 8, 2024 21:04
@seabbs seabbs enabled auto-merge (rebase) March 9, 2024 12:27
@nikosbosse nikosbosse disabled auto-merge March 9, 2024 18:52
@nikosbosse nikosbosse merged commit 3e434e4 into main Mar 9, 2024
@nikosbosse nikosbosse deleted the rules-to-metrics branch March 9, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename rules to metrics Implement Consistent naming of scoring rules/metrics

2 participants