Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
=======================================
Coverage 95.28% 95.28%
=======================================
Files 21 21
Lines 1632 1632
=======================================
Hits 1555 1555
Misses 77 77 ☔ View full report in Codecov by Sentry. |
seabbs
approved these changes
Mar 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #709.
This PR closes #610
Following the discussion in #610 this PR replaces occurrences of "rules" with "metrics" in the code
(to be precise, I updated the code by searching and replacing
rules_withmetrics__ruleswith_metricsrules =withmetrics =(ruleswith(metrics)The PR also updates a few instances in the docs to make it clear that "rules" means "metrics and scoring rules"
Checklist
lintr::lint_package()to check for style issues introduced by my changes.