Skip to content

Use stricter check to bypass validation of x[] #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikosbosse merged 2 commits into from
Sep 9, 2024
Merged

Use stricter check to bypass validation of x[] #897

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
333e220
Use stricter check to bypass validation of x[]
Bisaloo Aug 27, 2024
28ab142
Merge branch 'main' into dplyr-compatibility
nikosbosse Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions R/forecast.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,10 +693,17 @@ is_forecast_nominal <- function(x) {

out <- NextMethod()

# ...length() > 1: we don't need to revalidate x[]
# (identical(x, out) && ...length() == 1) is the best way I have found to
# selectively catch x[], which we don't want to revalidate. ...length()
# alone will skip cases with dplyr verbs and identical alone will skip cases
# where we used data.table := operator which will turn x into out before we
# arrive to this function.
is_dt_force_print <- identical(x, out) && ...length() == 1
# ...length() as it still returns 1 in x[] and then skips validations in
# undesired situation if we set ...length() > 1
# is.data.table: when [.data.table returns an atomic vector, it's clear it
# cannot be a valid forecast object, and it is likely intended by the user
if (...length() > 1 && data.table::is.data.table(out)) {
if (data.table::is.data.table(out) && !is_dt_force_print) {
# check whether subset object passes validation
validation <- try(
assert_forecast(forecast = out, verbose = FALSE),
Expand Down