Conversation
Contributor
|
do we need to move to test on 4.1 the error is not knowing about the base pipe |
Contributor
|
(need to then also update DESCRIPTION) |
elray1
approved these changes
Mar 10, 2025
Collaborator
elray1
left a comment
There was a problem hiding this comment.
the changes themselves look good to me. approving (subject to other comments from Sam and Seb)
Collaborator
Author
|
switched back to the old pipe |
seabbs
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #978
As suggested in #978, this PR adds an option to make the computation of p values optional.
Checklist
lintr::lint_package()to check for style issues introduced by my changes.