Skip to content

Make calculation of p-vals options in get_pairwise_comparisons()#994

Merged
seabbs merged 6 commits intomainfrom
p-vals
Mar 17, 2025
Merged

Make calculation of p-vals options in get_pairwise_comparisons()#994
seabbs merged 6 commits intomainfrom
p-vals

Conversation

@nikosbosse
Copy link
Copy Markdown
Collaborator

@nikosbosse nikosbosse commented Mar 10, 2025

Description

This PR closes #978

As suggested in #978, this PR adds an option to make the computation of p values optional.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@seabbs
Copy link
Copy Markdown
Contributor

seabbs commented Mar 10, 2025

do we need to move to test on 4.1 the error is not knowing about the base pipe

@sbfnk
Copy link
Copy Markdown
Contributor

sbfnk commented Mar 10, 2025

(need to then also update DESCRIPTION)

Copy link
Copy Markdown
Collaborator

@elray1 elray1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes themselves look good to me. approving (subject to other comments from Sam and Seb)

@nikosbosse nikosbosse requested a review from seabbs March 15, 2025 19:16
@nikosbosse
Copy link
Copy Markdown
Collaborator Author

switched back to the old pipe

@seabbs seabbs merged commit e85f7e0 into main Mar 17, 2025
9 checks passed
@seabbs seabbs deleted the p-vals branch March 17, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid computation of p-values in add_relative_skill()

4 participants