Allow for numeric imprecision for ordinal forecasts#997
Merged
nikosbosse merged 5 commits intomainfrom Apr 9, 2025
Merged
Conversation
seabbs
reviewed
Apr 7, 2025
seabbs
reviewed
Apr 7, 2025
Contributor
seabbs
left a comment
There was a problem hiding this comment.
Looks good. I think we might want to set it slightly bigger and potentially (though less sure) let the user specify it via an arg
seabbs
reviewed
Apr 7, 2025
Co-authored-by: Sam Abbott <contact@samabbott.co.uk>
seabbs
reviewed
Apr 9, 2025
seabbs
reviewed
Apr 9, 2025
seabbs
approved these changes
Apr 9, 2025
Contributor
seabbs
left a comment
There was a problem hiding this comment.
I simplified but otherwise this looks good to go
Co-authored-by: Sam Abbott <contact@samabbott.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #996
As discussed in #996, this PR allows for some numeric imprecision when checking whether all probabilities sum to 1.
Checklist
lintr::lint_package()to check for style issues introduced by my changes.