Skip to content

Allow for numeric imprecision for ordinal forecasts#997

Merged
nikosbosse merged 5 commits intomainfrom
ordinal-tolerance
Apr 9, 2025
Merged

Allow for numeric imprecision for ordinal forecasts#997
nikosbosse merged 5 commits intomainfrom
ordinal-tolerance

Conversation

@nikosbosse
Copy link
Copy Markdown
Collaborator

Description

This PR closes #996

As discussed in #996, this PR allows for some numeric imprecision when checking whether all probabilities sum to 1.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@nikosbosse nikosbosse requested a review from seabbs March 31, 2025 21:11
Copy link
Copy Markdown
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we might want to set it slightly bigger and potentially (though less sure) let the user specify it via an arg

Co-authored-by: Sam Abbott <contact@samabbott.co.uk>
Copy link
Copy Markdown
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simplified but otherwise this looks good to go

Co-authored-by: Sam Abbott <contact@samabbott.co.uk>
@nikosbosse nikosbosse merged commit 2d1bc8b into main Apr 9, 2025
9 checks passed
@nikosbosse nikosbosse deleted the ordinal-tolerance branch April 9, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow for within-tolerance error for ordinal forecasts

2 participants