Conversation
ghost
commented
Sep 18, 2018
ghost
commented
- update dashboard public url
Sebyd
reviewed
Sep 18, 2018
| var instance = DataService.GetInstance(filter.InstanceId); | ||
|
|
||
| if (!filter.IsAuthenticated && (string.IsNullOrEmpty(filter.Hash) || instance.Hash != filter.Hash)) | ||
| if (filter.InstanceId == 0 && filter.Hash == "undefined") |
Author
There was a problem hiding this comment.
yes, when the user is logged, and there is no hash parameter. It is sent as undefined.
Contributor
There was a problem hiding this comment.
Why is it marked as undefined? Who marks it that way. It should better be marked null.
Also, I think the instanceId should be made nullable on the filter, if it can be omitted. And verify if it is null instead of value 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.