Closed
Conversation
Minimal amount of work to get it py3-compatible; * tabs-to-spaces * 2to3 -w presentvalue.py * black presentvalue.py * Encapsulate code in def main() * Add test-code that only tries to launch the script, nothing more * Added test-data
markusdregi
force-pushed
the
present_travis_fix
branch
3 times, most recently
from
79396d3 to
b2bfc7b
Compare
markusdregi
force-pushed
the
present_travis_fix
branch
from
d094e0d to
db821d5
Compare
JensGM
reviewed
Sep 13, 2019
| dist: xenial | ||
| matrix: | ||
| include: | ||
| - python: '2.7' |
Contributor
Author
There was a problem hiding this comment.
Because we want to ensure similar behavior in Python 2 and 3, and currently there is not a single asset that has a Python 3 compatible FMU pipeline. I think we should remove it as soon as possible, but currently Python 2 support has value...
Contributor
Author
|
Cherry-picked into #1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.