Skip to content

validation error always reported as signature failure #21

@drortirosh

Description

@drortirosh

in _doUserOpValidation, any validation failure (revert reason) is ignored, and reported back as SIG_VALIDATION_FAILED - which is wrong.
SIG_VALIDATION_FAILED should only be returned if the signature is syntactically correct (e.g. the right length, right sub-fields (if any), etc), but resolves to the wrong signer.
the called method should return the SIG_VALIDATION_FAILED as part of the returned validation data
Instead, the original revert should be thrown (or wrapped with an outer revert, if needed)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions