feat: update install execution events #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zer0dot
approved these changes
Aug 1, 2024
Contributor
Zer0dot
left a comment
Zer0dot
left a comment
There was a problem hiding this comment.
Nice, another good catch-- looks good to me, nice and simple.
adamegyed
force-pushed
the
adam/install-execution-events
branch
from
0636473 to
721819e
Compare
adamegyed
force-pushed
the
adam/install-execution-events
branch
from
721819e to
fe41301
Compare
adamegyed
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the user-controlled manifests introduced in #101, the existing
ModuleInstalledevents no longer sufficiently describe what happens during an install or uninstall.Additionally, it is likely unnecessary to index the callback success field in the events.
Solution
ModuleInstalled,ModuleUninstalledtoExecutionInstalled,ExecutionUninstalled(to match Refactor: split IExecution out from IModule and rename vars to reflect new structure #117)indexed