Skip to content

feat: move account deploy event to factory #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamegyed merged 1 commit into from
Aug 15, 2024
Merged

feat: move account deploy event to factory #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/account/AccountFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ contract AccountFactory is Ownable {
IEntryPoint public immutable ENTRY_POINT;
address public immutable SINGLE_SIGNER_VALIDATION_MODULE;

event ModularAccountDeployed(address indexed account, address indexed owner, uint256 salt);

constructor(
IEntryPoint _entryPoint,
UpgradeableModularAccount _accountImpl,
Expand Down Expand Up @@ -55,6 +57,7 @@ contract AccountFactory is Ownable {
pluginInstallData,
new bytes[](0)
);
emit ModularAccountDeployed(addr, owner, salt);
}

return UpgradeableModularAccount(payable(addr));
Expand Down
3 changes: 0 additions & 3 deletions src/account/UpgradeableModularAccount.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ contract UpgradeableModularAccount is
bytes4 internal constant _1271_MAGIC_VALUE = 0x1626ba7e;
bytes4 internal constant _1271_INVALID = 0xffffffff;

event ModularAccountInitialized(IEntryPoint indexed entryPoint);

error NonCanonicalEncoding();
error NotEntryPoint();
error PostExecHookReverted(address module, uint32 entityId, bytes revertReason);
Expand Down Expand Up @@ -249,7 +247,6 @@ contract UpgradeableModularAccount is
bytes[] calldata hooks
) external initializer {
_installValidation(validationConfig, selectors, installData, hooks);
emit ModularAccountInitialized(_ENTRY_POINT);
}

/// @inheritdoc IModuleManager
Expand Down