feat: add moduleId #153
Merged
feat: add moduleId #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamegyed
approved these changes
Aug 22, 2024
jaypaik
force-pushed
the
08-22-feat_add_moduleId
branch
from
81a3700 to
79178c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Simplify module interface and align with the parent change that adds
accountId.Solution
Removed
moduleMetadata()in favor ofmoduleId(). Note that this does also remove the permission descriptors. We discussed this in our working group call, and decided that we'd leave this unspecified for now. If a standard forms around permissions, we'll revisit enforcing this in the standard.Note that this PR does not update the spec. I didn't want to create merge conflicts on that front, we can tackle after.