feat: add semi modular account support wording #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamegyed
reviewed
Aug 26, 2024
fangting-alchemy
force-pushed
the
fangting/semimodular
branch
from
68a77e5 to
edb20a1
Compare
adamegyed
approved these changes
Aug 26, 2024
|
|
||
| #### Semi-modular account | ||
|
|
||
| Account implementers may opt to design a semi-modular account, where certain features, such as default validation, are integrated into the core account. This approach should ensure compatibility with fully modular accounts, maintaining interoperability across different implementations. |
Contributor
There was a problem hiding this comment.
Nit: we should probably capitalize "should" as "SHOULD", as the top part of the spec states.
|
|
||
| #### Semi-modular account | ||
|
|
||
| Account implementers may opt to design a semi-modular account, where certain features, such as default validation, are integrated into the core account. This approach should ensure compatibility with fully modular accounts, maintaining interoperability across different implementations. |
Contributor
There was a problem hiding this comment.
We may want to clarify what it means to "ensure compatibility with fully modular accounts" - such as saying it should be possible to install new modules and use them, or use the interfaces, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.