feat: support global direct call validation #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice way to go about this! Wdyt of the security implications? I think it's fine, because a nefarious module could always just request whatever function to direct-call. So, overall, I think this is a nice streamlining change! |
Zer0dot
approved these changes
Aug 27, 2024
Contributor
Author
Yeah, similar reasoning on my end. The status of a validation as global vs not is part of the domain it gets set up with, so if you don't want to give it global access, you just don't set that as a parameter when you install it. But in some cases, it would be nice to grant it that permission. |
adamegyed
force-pushed
the
adam/direct-call-validation-type
branch
from
76f4270 to
a2dfa2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While we added support for direct-call validation in #90, this was only supported for individually added selectors, because the checking type defaulted to non-global. It would be useful to have "full" support for all validation types in this path.
Solution
Check for both global and selector-based validation applicability in the direct call path.
Do this by refactoring the checking functions to take an enum with types of
GLOBAL,SELECTOR, andEITHER.Refactor the direct call tests to randomize the validation type initialization, to test both cases.