fix: v0.8 review and polish #186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some updates to the spec after a review. This PR does not make any changes that would result in interface selectors changing. Will follow up on another PR for one change that would impact that for a more careful review.
Notable changes (non-exhaustive):
Modular Smart Contract Accounts and ModulestoModular Smart Contract Accounts. I think the latter implies that the standard would cover modules. Feel free to push back on this.The account MUST remove all supported interfaces as specified in the manifest.toThe account SHOULD remove all supported interfaces as specified in the manifest.This allows account implementations to choose custom behavior such as how to handle duplicate interface IDs.