Skip to content

Conversation

@jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Oct 15, 2024

Motivation

Solution

@octane-security-app
Copy link

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

  • ModuleManagerInternals.sol: The primary change updates the constant name from MAX_PRE_VALIDATION_HOOKS to MAX_VALIDATION_ASSOC_HOOKS.
  • Constants.sol: Updated to allow more types of validation-associated hooks to be registered.

🔗 Commit Hash: 8bf2511

@jaypaik jaypaik requested a review from adamegyed October 15, 2024 20:02
@jaypaik jaypaik merged commit 8135729 into develop Oct 15, 2024
@jaypaik jaypaik deleted the 10-15-fix_update_constant_name_for_MAX_PRE_VALIDATION_HOOKS branch October 15, 2024 20:03
@octane-security-app
Copy link

Overview

Vulnerabilities found: 2                                                                                
Severity breakdown: 1 Critical, 1 Medium

Detailed findings

src/account/AccountFactory.sol


🔗 Commit Hash: 8bf2511
🛡️ Octane Dashboard: All vulnerabilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants