feat: [v0.8-develop] Bump solidity version and remove optimizations #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
approved these changes
Apr 18, 2024
| unchecked { | ||
| --i; | ||
| } | ||
| // Decrement here, instead of in the loop body, to handle the case where length is 0. |
Collaborator
There was a problem hiding this comment.
To be a bit more clear, this is to be able to index into postHooksToRun[i] below instead of postHooksToRun[i-1]. Very minor optimization
Contributor
Author
There was a problem hiding this comment.
Ah I see. I tried setting the starting value of i to postHooksToRunLength - 1 at first, but this causes an underflow at length = 0, so I added this comment to indicate usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The purpose of the reference implementation should be to provide a readable and easy to comprehend implementation of the standard. Optimizations are useful for performance and necessary in production implementations of modular accounts and plugins, but impede readability of the reference implementation.
Specifically, we have lots of unchecked loop increments adding to SLOC without contributing to core account functionality. These are also automatically set to be unchecked in most cases starting with solidity v0.8.22.
Solution
Remove unchecked loop increments.
Bump solc to v0.8.25.
Remove an unused custom error type.