feat: [v0.8-develop] merge pre validation types #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Motivation and rationale very similar to #40. With validation function assignments merged, it makes sense to also merge pre-validation types.
"Merge" here means that when a pre validation hook is applied (an installed plugin address + a function id for the hook), then the two plugin functions
preUserOpValidationHookandpreRuntimeValidationHookshould both start to be called in their respective workflow paths, using the same function id.This reduces redundancy in manifests, and avoids the possibility of configuring one type of validation but not the other.
This simplification helps pave the way for multiple validation & better composability by reducing the size and complexity of account state.
Solution
preUserOpValidationHooksandpreRuntimeValidationHooksinto one fieldpreValidationHooks.getPreValidationHooksinIAccountLoupeto only return one array ofFunctionReferncetypes.