refactor: cleanup migrated content #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
adam/fix-singleownerplugin-manifest-bug
to
v0.8-develop
May 14, 2024 17:37
adamegyed
force-pushed
the
adam/cleanup-migrated-content
branch
from
d85d5bb to
2863993
Compare
jaypaik
approved these changes
May 14, 2024
Collaborator
jaypaik
left a comment
jaypaik
left a comment
There was a problem hiding this comment.
lgtm! heads up @sm-stack that we've migrated the plugin to https://github.com/erc6900/sample-plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As identified in #43, we planned to migrate libraries and sample plugins from the reference implementation out to other repositories. While that migration was underway, we kept the content in this repo, just commented out.
Specifically, content has been migrated to:
Now that the migration is complete, we can delete the local copies in the RI.
Solution
Remove the migrated content.