[1/n permissions] chore: remove existing permissions system #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howydev
force-pushed
the
howy/remove-permissions
branch
2 times, most recently
from
e069b7a to
73e57f3
Compare
adamegyed
force-pushed
the
adam/pre-validation-hook-assoc
branch
from
72be4f4 to
aeb416b
Compare
adamegyed
reviewed
Jun 12, 2024
Contributor
adamegyed
left a comment
adamegyed
left a comment
There was a problem hiding this comment.
This seems to be a duplicate of #65, but with the change of also removing the permitted calls in the fallback / native function path. We should rebase this onto that, because #65 also updates some of the tests that are commented out here.
For removing the permitted call flow, I'm OK to do that here, but note that once we remove that, any write-protected execution function (i.e. not marked as public) will no longer be callable via its original interface, they will need to go through the executeWithAuthorization path. We can always add permitted calls back if we think it's necessary.
adamegyed
force-pushed
the
adam/pre-validation-hook-assoc
branch
2 times, most recently
from
c872746 to
83a2ddb
Compare
howydev
force-pushed
the
howy/remove-permissions
branch
3 times, most recently
from
a1c31ce to
3941060
Compare
howydev
changed the title
adamegyed
force-pushed
the
adam/pre-validation-hook-assoc
branch
from
83a2ddb to
4d2390b
Compare
howydev
force-pushed
the
howy/remove-permissions
branch
from
3941060 to
ee0a657
Compare
howydev
changed the base branch from
adam/pre-validation-hook-assoc
to
adam/remove-ipluginexecutor
howydev
force-pushed
the
howy/remove-permissions
branch
2 times, most recently
from
107f7bf to
5d439e8
Compare
adamegyed
force-pushed
the
adam/remove-ipluginexecutor
branch
2 times, most recently
from
0aefb0f to
c9fcabf
Compare
howydev
force-pushed
the
howy/remove-permissions
branch
from
5d439e8 to
46dd1b2
Compare
howydev
force-pushed
the
howy/remove-permissions
branch
from
46dd1b2 to
db9960f
Compare
adamegyed
approved these changes
Jun 25, 2024
Contributor
adamegyed
left a comment
adamegyed
left a comment
There was a problem hiding this comment.
Looks good! Just have 1 nit
Collaborator
Author
|
addresses: erc6900/resources#50 |
adamegyed
pushed a commit
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
callPermittedandpermittedExternalCallsfrom the account and the plugin manifest