[2/n permissions] feat: add permission hooks #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howydev
force-pushed
the
howy/add-permissions
branch
from
8c35ead to
c4fa5d4
Compare
howydev
force-pushed
the
howy/remove-permissions
branch
from
5d439e8 to
46dd1b2
Compare
howydev
force-pushed
the
howy/remove-permissions
branch
from
46dd1b2 to
db9960f
Compare
howydev
force-pushed
the
howy/add-permissions
branch
from
c4fa5d4 to
990a842
Compare
adamegyed
approved these changes
Jun 25, 2024
Contributor
adamegyed
left a comment
adamegyed
left a comment
There was a problem hiding this comment.
This workflow looks correct, but the hooks themselves aren't called anywhere in this PR. So it's just setting up the storage fields for them, and the setter/getter functions.
Also it'd be nice to revisit the naming convention of "permission hooks", but I'm ok deferring that for now.
howydev
force-pushed
the
howy/add-permissions
branch
from
8b7aa5a to
ce2330e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog in this PR:
string[]toPluginMetadatafor permission plugins to declare ERC-7715 permission strings