[3/n permissions] feat: add execute user operation #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howydev
force-pushed
the
howy/add-permissions
branch
from
8c35ead to
c4fa5d4
Compare
howydev
force-pushed
the
howy/add-permissions
branch
from
c4fa5d4 to
990a842
Compare
adamegyed
reviewed
Jun 25, 2024
| } | ||
| } | ||
|
|
||
| if (permissionHooks.length > 0) { |
Collaborator
There was a problem hiding this comment.
The name is growing on me. : )
Zer0dot
reviewed
Jun 26, 2024
|
In case we are doing the UO flow without UO context, aren't we skipping all permission hooks currently? Permission hooks currently get only invoked in The information on this would however only be available in UO validation and not in execution. Should we forward this info somehow? It seems tricky to do permission hooks in this case. |
howydev
force-pushed
the
howy/add-permissions
branch
from
8b7aa5a to
ce2330e
Compare
adamegyed
reviewed
Jun 27, 2024
adamegyed
approved these changes
Jul 8, 2024
Contributor
adamegyed
left a comment
adamegyed
left a comment
There was a problem hiding this comment.
Looks good, just have 1 clarifying question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
executeUserOpin UO validationabi.encode(PackedUserOperation)if UO context is required, else sendabi.encodePacked(msg.sender, msg.value, msg.data)installValidationanduninstallValidation