style: [v0.8-develop] propose renaming default to global #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
approved these changes
Jun 21, 2024
Collaborator
jaypaik
left a comment
jaypaik
left a comment
There was a problem hiding this comment.
Until we come up with a better name for this, I prefer this over default.
howydev
approved these changes
Jun 21, 2024
huaweigu
approved these changes
Jun 24, 2024
adamegyed
force-pushed
the
adam/propose-rename-default-global
branch
from
384f946 to
2d599db
Compare
adamegyed
added a commit
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed in the working group sync, the default validation PR #63, and other PR comments, we may want to avoid using the term "default" when discussing default validation. Specifically, default implies that there is one specific validation used across many execution functions, and that it will be selected automatically, which are not the case.
Proposed Solution
One possible rename is to convert it to the term "global". This gets rid of the downsides of the term "default". However, it may carry the connotation that a "global" validation function applies to all functions, but in reality, a function must opt in to this validation.
Putting up this PR to discuss the proposed name change. Personally I'm OK with either.