refactor: [v0.8-develop] invert validation mapping #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaweigu
approved these changes
Jun 24, 2024
Contributor
huaweigu
left a comment
huaweigu
left a comment
There was a problem hiding this comment.
LGTM. This aligns better with most of the use cases, getting selectors through validation.
Another useful quick check could be isSelectorProtectedByValidation(FunctionReference validationFunction).
howydev
reviewed
Jun 24, 2024
adamegyed
force-pushed
the
adam/refactor-validation-mapping
branch
2 times, most recently
from
3866b0c to
364e06b
Compare
adamegyed
changed the base branch from
v0.8-develop
to
adam/self-call-restrictions
Contributor
Author
|
Changing base to point to #78, so this can be used as a base to build off of while waiting on blocking PRS. |
adamegyed
force-pushed
the
adam/self-call-restrictions
branch
from
1e415b1 to
7e76786
Compare
adamegyed
force-pushed
the
adam/refactor-validation-mapping
branch
from
364e06b to
b78c45b
Compare
adamegyed
force-pushed
the
adam/self-call-restrictions
branch
from
7e76786 to
2569ebd
Compare
adamegyed
force-pushed
the
adam/refactor-validation-mapping
branch
from
b78c45b to
05cea78
Compare
adamegyed
force-pushed
the
adam/self-call-restrictions
branch
from
2569ebd to
1d34450
Compare
adamegyed
force-pushed
the
adam/refactor-validation-mapping
branch
from
05cea78 to
4cfa5bf
Compare
adamegyed
force-pushed
the
adam/self-call-restrictions
branch
from
1d34450 to
5fda9a2
Compare
adamegyed
force-pushed
the
adam/refactor-validation-mapping
branch
from
4cfa5bf to
509ba03
Compare
adamegyed
force-pushed
the
adam/self-call-restrictions
branch
from
5fda9a2 to
ce90f55
Compare
adamegyed
force-pushed
the
adam/refactor-validation-mapping
branch
from
509ba03 to
1bfd893
Compare
adamegyed
added a commit
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As noted in a comment here, it may be useful to have the loupe functions expose "selectors per validation", rather than "validations per selectors".
Solution
Instead of storing an enumerable mapping
validationsinSelectorData, we can store an enumerable mapping ofselectorsinValidationData.This only changes the external loupe function
getValidations(bytes4 selector) external view returns (FunctionReference[] memory)togetSelectors(FunctionReference validationFunction) external view returns (bytes4[] memory). No other account functions or behavior is changed.