[2/n] rename validation res helper file and var names #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangting-alchemy
changed the title
adamegyed
approved these changes
Jul 11, 2024
Contributor
adamegyed
left a comment
adamegyed
left a comment
There was a problem hiding this comment.
Looks good. Might help first-time readers if we call it "ValidationResult" more explicitly, but I'm ok with "ValidationRes" too.
huaweigu
approved these changes
Jul 12, 2024
Contributor
huaweigu
left a comment
huaweigu
left a comment
There was a problem hiding this comment.
LGTM.
Do we also need to update function names such as _packValidationData?
fangting-alchemy
force-pushed
the
validation-names
branch
from
7458c66 to
92cd259
Compare
fangting-alchemy
added a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidationDatais now a data type in the codebase. We also havevalidationDatain the userOp call flow to represent intermediate and final validation results. RenamingvalidationDatatovalidationResto improve readability and avoid confusion.