Skip to content

Conversation

@zhang-alvin
Copy link
Contributor

@zhang-alvin zhang-alvin commented Mar 9, 2018

First of a series of PRs for various features that have been implemented. The primary feature of this PR is geometric model reconstruction from Proteus mesh data structures with proper topology but not shape information.

The model reconstruction handles 3D geometries and identifies external boundaries by the material flags.
The reconstruction capability is handled in SCOREC/core and assembling the requisite inputs are the primary modifications to Proteus.

  • add in 2D model reconstruction for jupyter notebook
  • update jupyter notebook to show capability

@zhang-alvin
Copy link
Contributor Author

The number of files/commits are a lot larger than they should be.

@zhang-alvin zhang-alvin force-pushed the zhanga/feature01_modelReconstruction branch from 08de36d to 39427cc Compare March 21, 2018 06:43
@zhang-alvin
Copy link
Contributor Author

History of feature branch was modified via cherry-picking of commits on top of master.

@zhang-alvin
Copy link
Contributor Author

@cekees hashdist/hashstack#998 needs to be pulled in before compilation can pass on Travis CI.

@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #708 into master will increase coverage by <.01%.
The diff coverage is 7.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
+ Coverage   48.12%   48.13%   +<.01%     
==========================================
  Files         380      380              
  Lines       85753    85729      -24     
==========================================
- Hits        41272    41269       -3     
+ Misses      44481    44460      -21
Impacted Files Coverage Δ
proteus/config/default.py 80.99% <0%> (-0.68%) ⬇️
proteus/MeshTools.py 54.38% <22.22%> (-0.07%) ⬇️
proteus/NumericalSolution.py 52.86% <3.57%> (+1.4%) ⬆️
proteus/tests/test_boundaryconditions.py 97.58% <0%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adc393f...a910680. Read the comment docs.

zhang-alvin and others added 5 commits March 26, 2018 14:38
…âmaterial arrays by adding a necessary input flag into MeshAdaptPUMIDrvr
… and set useModel variable if not in inputs
…c/proteus into zhanga/feature01_modelReconstruction
…ctures for 2D, and add default behavior to useModel flag
@zhang-alvin
Copy link
Contributor Author

Merging hashdist/hashstack#999 and updating the .hashstack_default commit should resolve the build issues after the most recent commits.

@zhang-alvin zhang-alvin requested a review from cekees April 23, 2018 03:25
@zhang-alvin
Copy link
Contributor Author

Whenever this PR is ready, it would be helpful to add the following to the merge commit message for bookkeeping purposes:

"PETTT Project (Number: PP-CFD-KY09-011-P3) Deliverable D2: Provide VMS-based error estimation, smoothed inputs to anisotropic mesh adaptation, and 3D discrete model reconstruction; (Task 2A) – anisotropic indicators at the interface."

Copy link
Member

@cekees cekees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@cekees cekees merged commit 889f0fb into master Apr 24, 2018
@cekees cekees deleted the zhanga/feature01_modelReconstruction branch April 24, 2018 01:25
Pedrohrw pushed a commit that referenced this pull request May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants