Skip to content

Conversation

@zhang-alvin
Copy link
Contributor

Third part of series that depends on #709.

The primary feature is the inclusion of a VMS-based error estimator to drive the computation of size-fields.
The capability might be a duplicate of existing Proteus-code, but will likely be migrated to a separate library eventually.

@codecov
Copy link

codecov bot commented May 1, 2018

Codecov Report

Merging #710 into master will increase coverage by <.01%.
The diff coverage is 38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   48.24%   48.24%   +<.01%     
==========================================
  Files         380      380              
  Lines       85900    85940      +40     
==========================================
+ Hits        41441    41465      +24     
- Misses      44459    44475      +16
Impacted Files Coverage Δ
...roteus/tests/MeshAdaptPUMI/test_poiseuilleError.py 96.34% <100%> (+0.04%) ⬆️
proteus/tests/MeshAdaptPUMI/test_gmshCheck.py 98.27% <100%> (+0.03%) ⬆️
proteus/NumericalSolution.py 52.91% <26.82%> (+0.04%) ⬆️
proteus/FemTools.py 36.04% <66.66%> (ø) ⬆️
proteus/tests/test_boundaryconditions.py 98.24% <0%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 185870a...1d41f40. Read the comment docs.

Copy link
Member

@cekees cekees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine once you clean up the print statements

err_reg = apf::createField(m,"ErrorRegion",apf::SCALAR,apf::getVoronoiShape(nsd,1));
errRho_reg = apf::createField(m,"ErrorDensity",apf::SCALAR,apf::getVoronoiShape(nsd,1));
errRel_reg = apf::createField(m,"RelativeError",apf::SCALAR,apf::getVoronoiShape(nsd,1));
std::cout<<"FLAG2\n";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove debugging statement

}
}
delta_T = deltaT;
std::cout<<"delta T "<<deltaT<<std::endl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove debugging statement

Copy link
Member

@cekees cekees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let me know when you're ready to merge this.

@zhang-alvin
Copy link
Contributor Author

Great. This branch can be merged in with commit message:

"In support of PETTT Project (Number: PP-CFD-KY09-011-P3) Deliverable D2: Provide VMS-based error estimation, smoothed inputs to anisotropic mesh adaptation, and 3D discrete model reconstruction; (Task 2A) – anisotropic indicators at the interface."

@cekees cekees merged commit fee1af3 into master May 3, 2018
@cekees cekees deleted the zhanga/feature03_VMS branch May 3, 2018 18:13
Pedrohrw pushed a commit that referenced this pull request May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants