-
Notifications
You must be signed in to change notification settings - Fork 58
PETTT Feature #3: VMS error estimator #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ze relationship. changed how minimum height is obtained. changed element to node transfer
…nd fixing tests for unsteady terms
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
==========================================
+ Coverage 48.24% 48.24% +<.01%
==========================================
Files 380 380
Lines 85900 85940 +40
==========================================
+ Hits 41441 41465 +24
- Misses 44459 44475 +16
Continue to review full report at Codecov.
|
cekees
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine once you clean up the print statements
| err_reg = apf::createField(m,"ErrorRegion",apf::SCALAR,apf::getVoronoiShape(nsd,1)); | ||
| errRho_reg = apf::createField(m,"ErrorDensity",apf::SCALAR,apf::getVoronoiShape(nsd,1)); | ||
| errRel_reg = apf::createField(m,"RelativeError",apf::SCALAR,apf::getVoronoiShape(nsd,1)); | ||
| std::cout<<"FLAG2\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove debugging statement
proteus/MeshAdaptPUMI/MeshFields.cpp
Outdated
| } | ||
| } | ||
| delta_T = deltaT; | ||
| std::cout<<"delta T "<<deltaT<<std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove debugging statement
cekees
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Let me know when you're ready to merge this.
|
Great. This branch can be merged in with commit message: "In support of PETTT Project (Number: PP-CFD-KY09-011-P3) Deliverable D2: Provide VMS-based error estimation, smoothed inputs to anisotropic mesh adaptation, and 3D discrete model reconstruction; (Task 2A) – anisotropic indicators at the interface." |
This reverts commit fee1af3.
Third part of series that depends on #709.
The primary feature is the inclusion of a VMS-based error estimator to drive the computation of size-fields.
The capability might be a duplicate of existing Proteus-code, but will likely be migrated to a separate library eventually.