Added several mutable functions#1
Merged
Merged
Conversation
…utable and #reset
Owner
|
I think mutable functions are a valuable addition. I may try to add some tests and documentation. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added #union_mutable, #intersect_mutable, #difference_mutable, #xor_mutable and #reset.
I found with a problem in which I needed to make several OR operations in a tree with thousands and thousands of nodes, where NODE.or |= NODE.child[i].or for every i-th child. So, ruby was creating
a lot of bitsets (one for every OR operation, and ended up using all my ram).
Since every time a NODE has merged its CHILD.or into it, this CHILD.or wasn't needed anymore, then I could track those Bitsets created and re-use (that's way the reason of #reset) them so Ruby woudn't have to create more Bitsets, wasting RAM (Garbage Collector wasn't deleting as frequent as NODE.or I was creating, and making a manual call to GC was slowing down this task by several minutes).