prevent printing exception from causing encoding exceptions #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's unclear why the body has the wrong encoding maybe our client isn't correctly defaulting to utf-8 when Content-Type is missing or something, so a deeper fix is probably a good idea someday. But this at least prevents exceptions on printing exceptions which obscures underlying errors. E.g.. we got this on the fulfillment preview endpoint for invalid addresses that included utf-8 but then got errors like these back when trying to print that:
Encoding::CompatibilityError: incompatible character encodings: ASCII-8BIT and UTF-8
Encoding::UndefinedConversionError ("\xC3" from ASCII-8BIT to UTF-8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's unclear why the body has the wrong encoding maybe our client isn't correctly defaulting to utf-8 when Content-Type is missing or something, so a deeper fix is probably a good idea someday. But this at least prevents exceptions on printing exceptions which obscures underlying errors. E.g.. we got this on the fulfillment preview endpoint for invalid addresses that included utf-8 but then got errors like these back when trying to print that:
Encoding::CompatibilityError: incompatible character encodings: ASCII-8BIT and UTF-8 Encoding::UndefinedConversionError ("\xC3" from ASCII-8BIT to UTF-8)