Skip to content

Handle transform errors with nice logging. #11

Merged
ericclemmons merged 1 commit intoericclemmons:masterfrom
steida:master
Dec 2, 2013
Merged

Handle transform errors with nice logging. #11
ericclemmons merged 1 commit intoericclemmons:masterfrom
steida:master

Conversation

@steida
Copy link
Contributor

@steida steida commented Nov 12, 2013

Try catch is must to not break Grunt watchers.

@ericclemmons
Copy link
Owner

This still causes a DING in the console, right? That was one problem I've had with other tools that, during watch, would fail silently and the remaining tasks kept running.

@steida
Copy link
Contributor Author

steida commented Nov 12, 2013

No DING. But also don't break watching, which is more important then DING. I used error code from https://github.com/gruntjs/grunt-contrib-coffee

@ericclemmons
Copy link
Owner

I'll have to double-check this, then. My react + grunt projects compile with browserify, then depends on that output for remaining build tasks.

Regarding importance, returning a proper error/success status from a script takes the cake, but that doesn't prevent this becoming a quiet or silent option!

See this similar thread: karma-runner/grunt-karma#39

@steida
Copy link
Contributor Author

steida commented Nov 15, 2013

@steida
Copy link
Contributor Author

steida commented Nov 15, 2013

In the other words, with my watcher it's beeping.

@steida
Copy link
Contributor Author

steida commented Nov 17, 2013

Never mind, I created own Grunt plugin https://github.com/steida/grunt-reactjsx. It leverages Grunt file api better and don't break file watchers.

@steida steida closed this Nov 17, 2013
@ericclemmons ericclemmons reopened this Nov 17, 2013
@ericclemmons ericclemmons merged commit 0941c2d into ericclemmons:master Dec 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants