update react-tools to ~0.4.0 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
React just updated to 0.4.1. Should we use that version instead? |
Contributor
Author
|
It's tilde version range so if you try now, you get 0.4.1 and this should work until next minor (see https://npmjs.org/doc/json.html#Tilde-Version-Ranges ). You could use 0.x since minor are not supposed to break either but it's a bit risky. Moreover, this allows you to bump grunt-react version number accordingly so we know that using grunt-react 0.4.x uses react-tools 0.4.x |
Owner
|
Oh, that's right! I use them myself, but I still find myself of being in the habit of explicitly setting the version :) Anyway, thanks for the PR. I'm merging down now! |
ericclemmons
added a commit
that referenced
this pull request
Jul 31, 2013
update react-tools to ~0.4.0
Owner
|
Now at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the latest react-tools version.
Currently, using grunt-react with react lib v0.4.0 in the browser prints warning messages and prevents internal optimizations.
Tests passes, this is not a major version, it shouldn't break...