Skip to content

development/production-only routes #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericclemmons merged 3 commits into from
Jan 18, 2019
Merged

development/production-only routes #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bf29ab
Add /dev-only page
ericclemmons Jan 18, 2019
b73c06b
In development, listen to non-exported servers so we at least 404
ericclemmons Jan 18, 2019
f478073
In production, don't add routes if no handler is exported
ericclemmons Jan 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/polydev/src/middleware/router/handle.production.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@ module.exports = async function handle(router, file, routes) {
routes.map(async ([httpMethod, route]) => {
const method = httpMethod.toLowerCase()
const exported = require(file)

if (!exported) {
return debug(
`Route %o does not have an exported handler from %o`,
route,
file.replace(process.cwd(), ".")
)
}

const handler = await (exported.default || exported)

debug(`router.${method}(%o, %o)`, route, file.replace(process.cwd(), "."))
Expand Down
6 changes: 4 additions & 2 deletions packages/polydev/src/middleware/router/launcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const routes = JSON.parse(routesString)
async function startHandler() {
const getLatestHandler = async () => {
const exported = require(handlerPath)
const handler = await (exported.default || exported)
const handler = exported ? await (exported.default || exported) : exported

return handler
}
Expand Down Expand Up @@ -82,8 +82,10 @@ async function startHandler() {
`${handlerPath.replace(
process.cwd(),
"."
)} does not return a Function or a Server`
)} does not return a Function, Server, or path to package.json`
)
// In development, at least listen on PORT so that we can 404
express().listen(PORT)
}

process.on("message", bridge(PORT))
Expand Down
25 changes: 25 additions & 0 deletions routes/dev-only/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
module.exports =
process.env.NODE_ENV === "development"
? (req, res) => {
res.send(`
<head>
<link href="https://fonts.googleapis.com/css?family=Quicksand:300,500" rel="stylesheet">
<link href="/_polydev/styles.css" rel="stylesheet">
</head>

<body>
<div id="splash"></div>

<section>
<main>
<h1>🤫 Shhhh!</h1>

<p>
This page is only available in <kbd>development</kbd>.
</p>
</main>
</section>
</body>
`)
}
: undefined
3 changes: 3 additions & 0 deletions routes/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ module.exports = (req, res) => {
<li>
<a href="/apollo-server">Apollo Server</a>
</li>
<li>
<a href="/dev-only">Development-Only Page</a>
</li>
<li>
<a href="/express">Express</a>
</li>
Expand Down