Fix "Failed to parse grammar" error for requests without grammar field#80
Draft
Fix "Failed to parse grammar" error for requests without grammar field#80
Conversation
- Change default grammar value from server config to empty string in server-task.cpp - Clear grammar-related fields when grammar is empty before sampler initialization - Prevents common_sampler_init from failing on empty grammar strings from OpenAI-compatible clients Co-authored-by: ericcurtin <1694275+ericcurtin@users.noreply.github.com>
Co-authored-by: ericcurtin <1694275+ericcurtin@users.noreply.github.com>
Co-authored-by: ericcurtin <1694275+ericcurtin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix grammar parsing issue with opencode
Fix "Failed to parse grammar" error for requests without grammar field
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAI-compatible clients sending chat completion requests without a
grammarfield receive "Failed to parse grammar" errors, blocking integration with tools like opencode.Root Cause
Two issues in the grammar parameter handling:
grammarfield defaults to server's global config instead of empty stringcommon_sampler_initcause nullptr returnsChanges
server-task.cpp line 281: Use empty string default instead of inheriting from server config
server-context.cpp lines 1058-1065: Clear grammar-related fields when grammar is empty before sampler initialization
This ensures
common_sampler_initdoesn't attempt to parse empty grammar strings while preserving behavior for requests with explicit grammar constraints.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.