Mini challenge 4 state management#52
Open
lex-villa wants to merge 37 commits intoerickwize:masterfrom
Open
Conversation
…/github.com/lex-villa/react-certification-2020 into Mini-Challenge-1--Core-Concepts-and-Styling
…and-Styling Mini challenge 1 core concepts and styling
erickwize
reviewed
Apr 20, 2021
Owner
erickwize
left a comment
erickwize
left a comment
There was a problem hiding this comment.
Comments
Good work Gio!
Please create the PR into your own branch, that way we can only give feedback on the added code, not the whole project.
I encourage you to do testing, so we can give you the Bootcamp certification.
Acceptance Criteria
- The search term is stored and retrieved from the Global Context correctly.
- The appearance theme is stored on the Global Context and applied correctly to the App UI.
-
useReducerhook is implemented correctly to manage the Global State.
Bonus Points
- Testing coverage is above 70%. (Please include a screenshot of the code coverage report in your PR description).
| @@ -0,0 +1,3 @@ | |||
| REACT_APP_GOOGLE_API_KEY=AIzaSyDN0P1UB4W39-XdmmA9wniCAlXA0f3WprU | |||
Owner
There was a problem hiding this comment.
I recommend removing this file, you should never upload these types of files
| useLayoutEffect(() => { | ||
| const { body } = document; | ||
| const App = () => { | ||
| const state = useContext(Context)[0]; |
Owner
There was a problem hiding this comment.
I recommend using:
const [state] = useContext(Context)
Comment on lines
+6
to
+7
| console.log('lista en video sugges'); | ||
| console.log(videosSuggested); |
Owner
There was a problem hiding this comment.
I suggested removing console.log from the code base
|
|
||
| const SearchInput = () => { | ||
| const [inputValue, setInputValue] = useState(''); | ||
| const dispatch = useContext(Context)[1]; |
Owner
There was a problem hiding this comment.
I recommend using: const [, dispatch] = useContext(Context)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.