Need <pack>false</pack>

[ericsink]

See aspnet/Microsoft.Data.Sqlite#320, especially comments therein from @natemcmaster

Worry about NuGet/Home#4432 and dotnet/sdk#847

[natemcmaster]

See also dotnet/sdk#843

[natemcmaster]

I can confirm that at least one problem here is that when creating a .NET Framework class library that depends on e_sqlite3.v110_xp, "dotnet pack" will end up putting runtimes\win7-x86\native\e_sqlite3.dll into the nuget package under "content" and "contentFiles".

Repro:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net451</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="sqlitepclraw.bundle_green" Version="1.1.2"/>
  </ItemGroup>

</Project>

dotnet restore
dotnet pack

(Using .NET Core CLI 1.0.0-rc4-004771).

[ericsink]

@natemcmaster You mentioned (over in the other repo PR) that the fix for this might be as simple as adding <pack>false</pack> to the content items. I would like to understand how this tag works. Can you point to any docs or information?

[bricelam]

See NuGet pack and restore as MSBuild targets

[ericsink]

I've confirmed that the the addition of <pack>false</pack> does fix the specific problem mentioned above (native dlls ending up in dotnet pack).

[ericsink]

Changing the title of this issue to make it more specific. Any other VS 2017 problems deserve their own issues.

[ericsink]

Fixed in 1.1.3