Fullstack-project review
This is a review of your Fullstack practice project. You may apply the suggestions presented here if you so wish, but you do not have to implement any further changes to receive the credits for your project.
What did I do
- I registered and logged in
- I added several items in a shopping cart
- I removed some items
- I changed the amount of some items in the cart
- I completed a purchase
- I looked at the past orders list and viewed their details
- I logged out
Feedback on the user experience
- The UI works and is easy to use
- There are appropriate validations and their error messages
- There should be some type of 'affordance' in the orders list, meaning something that indicates to the user that an order can be clicked to view it's details. This is not apparent from the order id as it doesn't even look like a link
- The user experience was quite buggy. At first I was not able to complete an order: nothing simply happened and the order did not appear in the orders-list. There were also small things that contributed to this feeling of bugginess: After logout, the view changes to the shopping cart which still shows the users order, but a page refresh fixes that.
- Trying to log in with a nonexistent username does not display any error, nothing happens. The request is returned with 200 OK status, but the response json reveals that the user was not found.
Feedback on the code
- Code is generally well-organized and readable. Some improvements for that:
- I would put the components into a folder like src/components to clean the src which has many different things like assets and types and App-root
- There are many quite large components, which are commented to explain what each part does. Usually a better solution is to divide the components into smaller pieces and organize the code so that it is self-explanatory
- Good use of technologies: Typescript, GraphQL backend, Redux, MaterialUI for styles.
- Frontend is tested, good
In general, the application is a nice fullstack-webstore which implements the most essential features for a webstore. It has room for improvement with regards to error notifications and affordance, and as a tester I would have liked some more suitable test items than ones with the name "test" or "string" :) However, the code implements nice technologies and a GraphQL-backend. Good job!
Fullstack-project review
This is a review of your Fullstack practice project. You may apply the suggestions presented here if you so wish, but you do not have to implement any further changes to receive the credits for your project.
What did I do
Feedback on the user experience
Feedback on the code
In general, the application is a nice fullstack-webstore which implements the most essential features for a webstore. It has room for improvement with regards to error notifications and affordance, and as a tester I would have liked some more suitable test items than ones with the name "test" or "string" :) However, the code implements nice technologies and a GraphQL-backend. Good job!