Skip to content

Remove HideGrid() from all Dashboard charts #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
Feb 19, 2026
Merged

Remove HideGrid() from all Dashboard charts #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions Dashboard/Controls/MemoryContent.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ private void LoadMemoryStatsOverviewChart(List<MemoryStatsItem> memoryData, int
MemoryStatsOverviewChart.Plot.Axes.DateTimeTicksBottom();
MemoryStatsOverviewChart.Plot.Axes.SetLimitsX(xMin, xMax);
MemoryStatsOverviewChart.Plot.YLabel("MB");
MemoryStatsOverviewChart.Plot.HideGrid();
// Fixed negative space for legend
MemoryStatsOverviewChart.Plot.Axes.AutoScaleY();
var memOverviewLimits = MemoryStatsOverviewChart.Plot.Axes.GetLimits();
Expand Down Expand Up @@ -476,7 +475,6 @@ private void LoadMemoryGrantsChart(IEnumerable<MemoryGrantStatsItem> data, int h
MemoryGrantsChart.Plot.Axes.DateTimeTicksBottom();
MemoryGrantsChart.Plot.Axes.SetLimitsX(xMin, xMax);
MemoryGrantsChart.Plot.YLabel("MB");
MemoryGrantsChart.Plot.HideGrid();
// Fixed negative space for legend
MemoryGrantsChart.Plot.Axes.AutoScaleY();
var grantsLimits = MemoryGrantsChart.Plot.Axes.GetLimits();
Expand Down Expand Up @@ -587,7 +585,6 @@ private void LoadMemoryClerksChart(List<MemoryClerksItem> data, int hoursBack, D
MemoryClerksChart.Plot.Axes.DateTimeTicksBottom();
MemoryClerksChart.Plot.Axes.SetLimitsX(xMin, xMax);
MemoryClerksChart.Plot.YLabel("MB");
MemoryClerksChart.Plot.HideGrid();
// Fixed negative space for legend
MemoryClerksChart.Plot.Axes.AutoScaleY();
var clerksLimits = MemoryClerksChart.Plot.Axes.GetLimits();
Expand Down Expand Up @@ -737,7 +734,6 @@ private void LoadPlanCacheChart(IEnumerable<PlanCacheStatsItem> data, int hoursB
PlanCacheChart.Plot.Axes.DateTimeTicksBottom();
PlanCacheChart.Plot.Axes.SetLimitsX(xMin, xMax);
PlanCacheChart.Plot.YLabel("MB");
PlanCacheChart.Plot.HideGrid();
// Fixed negative space for legend
PlanCacheChart.Plot.Axes.AutoScaleY();
var planCacheLimits = PlanCacheChart.Plot.Axes.GetLimits();
Expand Down Expand Up @@ -857,7 +853,6 @@ private void LoadMemoryPressureEventsChart(IEnumerable<MemoryPressureEventItem>
MemoryPressureEventsChart.Plot.Axes.DateTimeTicksBottom();
MemoryPressureEventsChart.Plot.Axes.SetLimitsX(xMin, xMax);
MemoryPressureEventsChart.Plot.YLabel("Event Count");
MemoryPressureEventsChart.Plot.HideGrid();
// Fixed negative space for legend
MemoryPressureEventsChart.Plot.Axes.AutoScaleY();
var pressureLimits = MemoryPressureEventsChart.Plot.Axes.GetLimits();
Expand Down
2 changes: 0 additions & 2 deletions Dashboard/Controls/QueryPerformanceContent.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,7 +971,6 @@ private void LoadDurationChart(WpfPlot chart, IEnumerable<DurationTrendItem> tre
chart.Plot.Axes.DateTimeTicksBottom();
chart.Plot.Axes.SetLimitsX(xMin, xMax);
chart.Plot.YLabel("Duration (ms/sec)");
chart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(chart);
chart.Refresh();
}
Expand Down Expand Up @@ -1027,7 +1026,6 @@ private void LoadExecChart(IEnumerable<ExecutionTrendItem> execTrends, int hours
QueryPerfTrendsExecChart.Plot.Axes.DateTimeTicksBottom();
QueryPerfTrendsExecChart.Plot.Axes.SetLimitsX(xMin, xMax);
QueryPerfTrendsExecChart.Plot.YLabel("Executions/sec");
QueryPerfTrendsExecChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(QueryPerfTrendsExecChart);
QueryPerfTrendsExecChart.Refresh();
}
Expand Down
12 changes: 0 additions & 12 deletions Dashboard/Controls/ResourceMetricsContent.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,6 @@ private void LoadLatchStatsChart(IEnumerable<LatchStatsItem> data, int hoursBack
LatchStatsChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(LatchStatsChart);
LatchStatsChart.Plot.YLabel("Wait Time (ms/sec)");
LatchStatsChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(LatchStatsChart);
LatchStatsChart.Refresh();
}
Expand Down Expand Up @@ -450,7 +449,6 @@ private void LoadSpinlockStatsChart(IEnumerable<SpinlockStatsItem> data, int hou
SpinlockStatsChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(SpinlockStatsChart);
SpinlockStatsChart.Plot.YLabel("Collisions/sec");
SpinlockStatsChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(SpinlockStatsChart);
SpinlockStatsChart.Refresh();
}
Expand Down Expand Up @@ -559,7 +557,6 @@ private void LoadCombinedTempDbLatencyChart(List<FileIoLatencyTimeSeriesItem> da
TempDbLatencyChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(TempDbLatencyChart);
TempDbLatencyChart.Plot.YLabel("Latency (ms)");
TempDbLatencyChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(TempDbLatencyChart);
TempDbLatencyChart.Refresh();
}
Expand Down Expand Up @@ -665,7 +662,6 @@ private void LoadTempdbStatsChart(IEnumerable<TempdbStatsItem> data, int hoursBa
TempdbStatsChart.Plot.Axes.SetLimitsX(xMin, xMax);
TempdbStatsChart.Plot.Axes.AutoScaleY();
TempdbStatsChart.Plot.YLabel("MB");
TempdbStatsChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(TempdbStatsChart);
TempdbStatsChart.Refresh();
}
Expand Down Expand Up @@ -837,7 +833,6 @@ private void LoadSessionStatsChart(IEnumerable<SessionStatsItem> data, int hours
SessionStatsChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(SessionStatsChart);
SessionStatsChart.Plot.YLabel("Session Count");
SessionStatsChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(SessionStatsChart);
SessionStatsChart.Refresh();
}
Expand Down Expand Up @@ -951,7 +946,6 @@ private void LoadFileIoChart(ScottPlot.WPF.WpfPlot chart, List<FileIoLatencyTime
chart.Plot.Axes.DateTimeTicksBottom();
chart.Plot.Axes.SetLimitsX(xMin, xMax);
chart.Plot.YLabel(yLabel);
chart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(chart);
chart.Refresh();
}
Expand Down Expand Up @@ -1043,7 +1037,6 @@ private void LoadServerTrendsCpuChart(IEnumerable<CpuSpikeItem> cpuData, int hou
ServerUtilTrendsCpuChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(ServerUtilTrendsCpuChart);
ServerUtilTrendsCpuChart.Plot.YLabel("CPU %");
ServerUtilTrendsCpuChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(ServerUtilTrendsCpuChart);
ServerUtilTrendsCpuChart.Refresh();
}
Expand Down Expand Up @@ -1105,7 +1098,6 @@ private void LoadServerTrendsTempdbChart(IEnumerable<TempdbStatsItem> tempdbData
ServerUtilTrendsTempdbChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(ServerUtilTrendsTempdbChart);
ServerUtilTrendsTempdbChart.Plot.YLabel("MB");
ServerUtilTrendsTempdbChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(ServerUtilTrendsTempdbChart);
ServerUtilTrendsTempdbChart.Refresh();
}
Expand Down Expand Up @@ -1211,7 +1203,6 @@ private void LoadServerTrendsMemoryChart(IEnumerable<MemoryStatsItem> memoryData
ServerUtilTrendsMemoryChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(ServerUtilTrendsMemoryChart);
ServerUtilTrendsMemoryChart.Plot.YLabel("MB");
ServerUtilTrendsMemoryChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(ServerUtilTrendsMemoryChart);
ServerUtilTrendsMemoryChart.Refresh();
}
Expand Down Expand Up @@ -1287,7 +1278,6 @@ private void LoadServerTrendsPerfmonChart(IEnumerable<PerfmonStatsItem> perfmonD
ServerUtilTrendsPerfmonChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(ServerUtilTrendsPerfmonChart);
ServerUtilTrendsPerfmonChart.Plot.YLabel("Per Second");
ServerUtilTrendsPerfmonChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(ServerUtilTrendsPerfmonChart);
ServerUtilTrendsPerfmonChart.Refresh();
}
Expand Down Expand Up @@ -1791,7 +1781,6 @@ private void LoadPerfmonCountersChart(List<PerfmonStatsItem>? data, int hoursBac
PerfmonCountersChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(PerfmonCountersChart);
PerfmonCountersChart.Plot.YLabel("Value/sec");
PerfmonCountersChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(PerfmonCountersChart);
PerfmonCountersChart.Refresh();
}
Expand Down Expand Up @@ -2167,7 +2156,6 @@ private void LoadWaitStatsDetailChart(List<WaitStatsDataPoint>? data, int hoursB
WaitStatsDetailChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(WaitStatsDetailChart);
WaitStatsDetailChart.Plot.YLabel(useAvgPerWait ? "Avg Wait Time (ms/wait)" : "Wait Time (ms/sec)");
WaitStatsDetailChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(WaitStatsDetailChart);
WaitStatsDetailChart.Refresh();
}
Expand Down
18 changes: 0 additions & 18 deletions Dashboard/Controls/SystemEventsContent.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,6 @@ private void LoadCorruptionEventsCharts(List<HealthParserSystemHealthItem> data,
BadPagesChart.Plot.Axes.DateTimeTicksBottom();
BadPagesChart.Plot.Axes.SetLimitsX(xMin, xMax);
BadPagesChart.Plot.YLabel("Count");
BadPagesChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(BadPagesChart);
BadPagesChart.Refresh();

Expand Down Expand Up @@ -504,7 +503,6 @@ private void LoadCorruptionEventsCharts(List<HealthParserSystemHealthItem> data,
DumpRequestsChart.Plot.Axes.DateTimeTicksBottom();
DumpRequestsChart.Plot.Axes.SetLimitsX(xMin, xMax);
DumpRequestsChart.Plot.YLabel("Count");
DumpRequestsChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(DumpRequestsChart);
DumpRequestsChart.Refresh();

Expand Down Expand Up @@ -534,7 +532,6 @@ private void LoadCorruptionEventsCharts(List<HealthParserSystemHealthItem> data,
AccessViolationsChart.Plot.Axes.DateTimeTicksBottom();
AccessViolationsChart.Plot.Axes.SetLimitsX(xMin, xMax);
AccessViolationsChart.Plot.YLabel("Count");
AccessViolationsChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(AccessViolationsChart);
AccessViolationsChart.Refresh();

Expand Down Expand Up @@ -564,7 +561,6 @@ private void LoadCorruptionEventsCharts(List<HealthParserSystemHealthItem> data,
WriteAccessViolationsChart.Plot.Axes.DateTimeTicksBottom();
WriteAccessViolationsChart.Plot.Axes.SetLimitsX(xMin, xMax);
WriteAccessViolationsChart.Plot.YLabel("Count");
WriteAccessViolationsChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(WriteAccessViolationsChart);
WriteAccessViolationsChart.Refresh();
}
Expand Down Expand Up @@ -606,7 +602,6 @@ private void LoadContentionEventsCharts(List<HealthParserSystemHealthItem> data,
NonYieldingTasksChart.Plot.Axes.DateTimeTicksBottom();
NonYieldingTasksChart.Plot.Axes.SetLimitsX(xMin, xMax);
NonYieldingTasksChart.Plot.YLabel("Count");
NonYieldingTasksChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(NonYieldingTasksChart);
NonYieldingTasksChart.Refresh();

Expand Down Expand Up @@ -636,7 +631,6 @@ private void LoadContentionEventsCharts(List<HealthParserSystemHealthItem> data,
LatchWarningsChart.Plot.Axes.DateTimeTicksBottom();
LatchWarningsChart.Plot.Axes.SetLimitsX(xMin, xMax);
LatchWarningsChart.Plot.YLabel("Count");
LatchWarningsChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(LatchWarningsChart);
LatchWarningsChart.Refresh();

Expand Down Expand Up @@ -700,7 +694,6 @@ private void LoadContentionEventsCharts(List<HealthParserSystemHealthItem> data,
SickSpinlocksChart.Plot.Axes.DateTimeTicksBottom();
SickSpinlocksChart.Plot.Axes.SetLimitsX(xMin, xMax);
SickSpinlocksChart.Plot.YLabel("Backoffs");
SickSpinlocksChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(SickSpinlocksChart);
SickSpinlocksChart.Refresh();

Expand Down Expand Up @@ -752,7 +745,6 @@ private void LoadContentionEventsCharts(List<HealthParserSystemHealthItem> data,
CpuComparisonChart.Plot.Axes.SetLimitsX(xMin, xMax);
CpuComparisonChart.Plot.Axes.SetLimitsY(0, 100); // Fixed Y-axis for CPU percentage
CpuComparisonChart.Plot.YLabel("CPU %");
CpuComparisonChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(CpuComparisonChart);
CpuComparisonChart.Refresh();
}
Expand Down Expand Up @@ -853,7 +845,6 @@ private void LoadSevereErrorsChart(IEnumerable<HealthParserSevereErrorItem> data
SevereErrorsChart.Plot.Axes.DateTimeTicksBottom();
SevereErrorsChart.Plot.Axes.SetLimitsX(xMin, xMax);
SevereErrorsChart.Plot.YLabel("Event Count");
SevereErrorsChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(SevereErrorsChart);
SevereErrorsChart.Refresh();
}
Expand Down Expand Up @@ -1013,7 +1004,6 @@ private void LoadIOIssuesChart(IEnumerable<HealthParserIOIssueItem> data, int ho
IOIssuesChart.Plot.Axes.DateTimeTicksBottom();
IOIssuesChart.Plot.Axes.SetLimitsX(xMin, xMax);
IOIssuesChart.Plot.YLabel("Count");
IOIssuesChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(IOIssuesChart);
IOIssuesChart.Refresh();
}
Expand Down Expand Up @@ -1108,7 +1098,6 @@ private void LoadLongestPendingIOChart(IEnumerable<HealthParserIOIssueItem> data
LongestPendingIOChart.Plot.Axes.DateTimeTicksBottom();
LongestPendingIOChart.Plot.Axes.SetLimitsX(xMin, xMax);
LongestPendingIOChart.Plot.YLabel("Duration (ms)");
LongestPendingIOChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(LongestPendingIOChart);
LongestPendingIOChart.Refresh();
}
Expand Down Expand Up @@ -1208,7 +1197,6 @@ long ParseNonYield(string? value)
SchedulerIssuesChart.Plot.Axes.DateTimeTicksBottom();
SchedulerIssuesChart.Plot.Axes.SetLimitsX(xMin, xMax);
SchedulerIssuesChart.Plot.YLabel("Total Non-Yield Time (ms)");
SchedulerIssuesChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(SchedulerIssuesChart);
SchedulerIssuesChart.Refresh();
}
Expand Down Expand Up @@ -1359,7 +1347,6 @@ private void LoadMemoryConditionsChart(IEnumerable<HealthParserMemoryConditionIt
MemoryConditionsChart.Plot.Axes.DateTimeTicksBottom();
MemoryConditionsChart.Plot.Axes.SetLimitsX(xMin, xMax);
MemoryConditionsChart.Plot.YLabel("Count");
MemoryConditionsChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(MemoryConditionsChart);
MemoryConditionsChart.Refresh();
}
Expand Down Expand Up @@ -1532,7 +1519,6 @@ private void LoadCPUTasksChart(IEnumerable<HealthParserCPUTasksItem> data, int h
CPUTasksChart.Plot.Axes.DateTimeTicksBottom();
CPUTasksChart.Plot.Axes.SetLimitsX(xMin, xMax);
CPUTasksChart.Plot.YLabel("Workers");
CPUTasksChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(CPUTasksChart);
CPUTasksChart.Refresh();
}
Expand Down Expand Up @@ -1739,7 +1725,6 @@ private void LoadMemoryBrokerChart(IEnumerable<HealthParserMemoryBrokerItem> dat
{
chart.Plot.Axes.DateTimeTicksBottom();
chart.Plot.Axes.SetLimitsX(xMin, xMax);
chart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(chart);
chart.Refresh();
}
Expand Down Expand Up @@ -1894,7 +1879,6 @@ private void LoadMemoryNodeOOMChart(IEnumerable<HealthParserMemoryNodeOOMItem> d
MemoryNodeOOMChart.Plot.Axes.DateTimeTicksBottom();
MemoryNodeOOMChart.Plot.Axes.SetLimitsX(xMin, xMax);
MemoryNodeOOMChart.Plot.YLabel("Event Count");
MemoryNodeOOMChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(MemoryNodeOOMChart);
MemoryNodeOOMChart.Refresh();
}
Expand Down Expand Up @@ -1944,7 +1928,6 @@ private void LoadMemoryNodeOOMUtilChart(IEnumerable<HealthParserMemoryNodeOOMIte

MemoryNodeOOMUtilChart.Plot.Axes.DateTimeTicksBottom();
MemoryNodeOOMUtilChart.Plot.Axes.SetLimitsX(xMin, xMax);
MemoryNodeOOMUtilChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(MemoryNodeOOMUtilChart);
MemoryNodeOOMUtilChart.Refresh();
}
Expand Down Expand Up @@ -2048,7 +2031,6 @@ private void LoadMemoryNodeOOMMemoryChart(IEnumerable<HealthParserMemoryNodeOOMI

MemoryNodeOOMMemoryChart.Plot.Axes.DateTimeTicksBottom();
MemoryNodeOOMMemoryChart.Plot.Axes.SetLimitsX(xMin, xMax);
MemoryNodeOOMMemoryChart.Plot.HideGrid();
TabHelpers.LockChartVerticalAxis(MemoryNodeOOMMemoryChart);
MemoryNodeOOMMemoryChart.Refresh();
}
Expand Down
Loading