Skip to content

Raise wait stats cap so poison waits are never dropped #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
Feb 19, 2026
Merged

Raise wait stats cap so poison waits are never dropped #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dashboard/Controls/ResourceMetricsContent.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
<StackPanel Grid.Row="1" Orientation="Horizontal" Margin="5,2">
<Button Content="Top Waits" Click="WaitTypes_SelectAll_Click" Padding="6,2" FontSize="10" Margin="0,0,5,0"/>
<Button Content="Clear All" Click="WaitTypes_ClearAll_Click" Padding="6,2" FontSize="10"/>
<TextBlock x:Name="WaitTypeCountText" Text="0 / 20 selected" FontSize="10" Foreground="{DynamicResource ForegroundMutedBrush}" VerticalAlignment="Center" Margin="8,0,0,0"/>
<TextBlock x:Name="WaitTypeCountText" Text="0 / 30 selected" FontSize="10" Foreground="{DynamicResource ForegroundMutedBrush}" VerticalAlignment="Center" Margin="8,0,0,0"/>
</StackPanel>
<TextBox Grid.Row="2" x:Name="WaitTypeSearchBox" Margin="5,2" Height="24" FontSize="11"
TextChanged="WaitTypeSearch_TextChanged"
Expand Down
4 changes: 2 additions & 2 deletions Dashboard/Controls/ResourceMetricsContent.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1923,8 +1923,8 @@ private void UpdateWaitTypeCount()
{
if (_waitTypeItems == null || WaitTypeCountText == null) return;
int count = _waitTypeItems.Count(x => x.IsSelected);
WaitTypeCountText.Text = $"{count} / 20 selected";
WaitTypeCountText.Foreground = count >= 20
WaitTypeCountText.Text = $"{count} / 30 selected";
WaitTypeCountText.Foreground = count >= 30
? new System.Windows.Media.SolidColorBrush((System.Windows.Media.Color)System.Windows.Media.ColorConverter.ConvertFromString("#E57373")!)
: (System.Windows.Media.Brush)FindResource("ForegroundMutedBrush");
}
Expand Down
6 changes: 3 additions & 3 deletions Dashboard/Helpers/TabHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public static class TabHelpers

/// <summary>
/// Returns the set of wait types that should be selected by default:
/// poison waits + usual suspects + top 10 by total wait time (deduped), capped at 20.
/// poison waits + usual suspects + top 10 by total wait time (deduped), capped at 30.
/// The availableWaitTypes list must be sorted by total wait time descending.
/// </summary>
public static HashSet<string> GetDefaultWaitTypes(IList<string> availableWaitTypes)
Expand All @@ -108,11 +108,11 @@ public static HashSet<string> GetDefaultWaitTypes(IList<string> availableWaitTyp
if (w.StartsWith(prefix, StringComparison.OrdinalIgnoreCase))
defaults.Add(w);

// 4. Top 10 by total wait time (items not already in the set), hard cap at 20 total
// 4. Top 10 by total wait time (items not already in the set), hard cap at 30 total
int added = 0;
foreach (var w in availableWaitTypes)
{
if (defaults.Count >= 20) break;
if (defaults.Count >= 30) break;
if (added >= 10) break;
if (defaults.Add(w))
{
Expand Down
2 changes: 1 addition & 1 deletion Lite/Controls/ServerTab.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
<StackPanel Grid.Row="1" Orientation="Horizontal" Margin="0,0,0,4">
<Button Content="Top Waits" Click="WaitTypeSelectAll_Click" Padding="6,2" Margin="0,0,4,0" FontSize="11"/>
<Button Content="Clear All" Click="WaitTypeClearAll_Click" Padding="6,2" FontSize="11"/>
<TextBlock x:Name="WaitTypeCountText" Text="0 / 20 selected" FontSize="10" Foreground="{StaticResource ForegroundMutedBrush}" VerticalAlignment="Center" Margin="8,0,0,0"/>
<TextBlock x:Name="WaitTypeCountText" Text="0 / 30 selected" FontSize="10" Foreground="{StaticResource ForegroundMutedBrush}" VerticalAlignment="Center" Margin="8,0,0,0"/>
</StackPanel>
<TextBox Grid.Row="2" x:Name="WaitTypeSearchBox" TextChanged="WaitTypeSearch_TextChanged"
Margin="0,0,0,4" Padding="4,2"/>
Expand Down
6 changes: 3 additions & 3 deletions Lite/Controls/ServerTab.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,7 +1119,7 @@ private static HashSet<string> GetDefaultWaitTypes(List<string> availableWaitTyp
int added = 0;
foreach (var w in availableWaitTypes)
{
if (defaults.Count >= 20) break;
if (defaults.Count >= 30) break;
if (added >= 10) break;
if (defaults.Add(w)) { added++; }
}
Expand Down Expand Up @@ -1156,8 +1156,8 @@ private void UpdateWaitTypeCount()
{
if (_waitTypeItems == null || WaitTypeCountText == null) return;
int count = _waitTypeItems.Count(x => x.IsSelected);
WaitTypeCountText.Text = $"{count} / 20 selected";
WaitTypeCountText.Foreground = count >= 20
WaitTypeCountText.Text = $"{count} / 30 selected";
WaitTypeCountText.Foreground = count >= 30
? new SolidColorBrush((System.Windows.Media.Color)ColorConverter.ConvertFromString("#E57373")!)
: (System.Windows.Media.Brush)FindResource("ForegroundMutedBrush");
}
Expand Down
2 changes: 1 addition & 1 deletion install/47_create_reporting_views.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ WITH
WHERE ws.collection_time >= DATEADD(HOUR, -1, SYSDATETIME())
AND ws.wait_time_ms_delta > 0
)
SELECT TOP (20)
SELECT TOP (50)
wait_type = rw.wait_type,
wait_time_ms = rw.wait_time_ms_delta,
wait_time_sec = rw.wait_time_ms_delta / 1000.0,
Expand Down
Loading