Skip to content

Improve experience when adding server - Save tests the connection #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 14 commits into from
Feb 26, 2026
Merged

Improve experience when adding server - Save tests the connection #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c2339e6
implements [FEATURE] Behaviour when saving a connection
ClaudioESSilva Feb 24, 2026
1c06595
remove the "enable" from Dashboard and tidy up (remove duplicated con…
ClaudioESSilva Feb 25, 2026
97f982d
disable "Save" button when testing the connection
ClaudioESSilva Feb 25, 2026
e3965ae
tidy up code (remove duplicated code too)
ClaudioESSilva Feb 25, 2026
cb80a63
Fix "Dashboard XAML missing RowDefinition"
ClaudioESSilva Feb 26, 2026
d8bf920
Remove "IsEnabled" property
ClaudioESSilva Feb 26, 2026
fb49c1c
Put "SELECT @@VERSION" in the connection test back for Lite
ClaudioESSilva Feb 26, 2026
1c34344
Put "SELECT @@VERSION" in the connection test in Dashboard too
ClaudioESSilva Feb 26, 2026
b93a48b
Use SqlConnectionStringBuilder as Lite
ClaudioESSilva Feb 26, 2026
ac615ae
Tidy code like Lite
ClaudioESSilva Feb 26, 2026
0ae6d92
Lite: Add Failure feedback using MessageBox, not inline StatusText
ClaudioESSilva Feb 26, 2026
0c54163
Lite: Use MessageBox also for "Test Connection"
ClaudioESSilva Feb 26, 2026
f99e81e
Clear StatusText label after test
ClaudioESSilva Feb 26, 2026
17df4a9
Add MFA to Dashboard
ClaudioESSilva Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 34 additions & 17 deletions Dashboard/AddServerDialog.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
<RowDefinition Height="Auto"/>
<RowDefinition Height="*"/>
<RowDefinition Height="Auto"/>
<RowDefinition Height="Auto"/>
</Grid.RowDefinitions>

<!-- Header -->
Expand All @@ -50,29 +51,40 @@
<!-- Authentication Type -->
<TextBlock Text="Authentication:" FontWeight="Bold" Margin="0,0,0,5"
Foreground="{DynamicResource ForegroundBrush}"/>
<StackPanel Orientation="Horizontal" Margin="0,0,0,15">
<StackPanel Margin="0,0,0,15">
<RadioButton x:Name="WindowsAuthRadio" Content="Windows Authentication"
GroupName="Auth" IsChecked="True"
Foreground="{DynamicResource ForegroundBrush}"
Checked="AuthType_Changed" Margin="0,0,20,0"/>
Checked="AuthType_Changed" Margin="0,0,0,4"/>
<RadioButton x:Name="SqlAuthRadio" Content="SQL Server Authentication"
GroupName="Auth"
Foreground="{DynamicResource ForegroundBrush}"
Checked="AuthType_Changed"/>
Checked="AuthType_Changed" Margin="0,0,0,4"/>
<RadioButton x:Name="EntraMfaAuthRadio" Content="Microsoft Entra MFA"
GroupName="Auth"
Foreground="{DynamicResource ForegroundBrush}"
Checked="AuthType_Changed"
ToolTip="Interactive authentication with MFA for Azure SQL Database."/>
</StackPanel>

<!-- SQL Authentication Fields (initially disabled) -->
<Border x:Name="SqlAuthPanel" IsEnabled="False">
<StackPanel>
<TextBlock Text="Username:" FontWeight="Bold" Margin="0,0,0,5"
Foreground="{DynamicResource ForegroundBrush}"/>
<TextBox x:Name="UsernameTextBox" Height="25" Margin="0,0,0,15"/>
<!-- SQL Authentication Fields -->
<StackPanel x:Name="SqlAuthPanel" Visibility="Collapsed" Margin="0,0,0,15">
<TextBlock Text="Username:" FontWeight="Bold" Margin="0,0,0,5"
Foreground="{DynamicResource ForegroundBrush}"/>
<TextBox x:Name="UsernameTextBox" Height="25" Margin="0,0,0,15"/>

<TextBlock Text="Password:" FontWeight="Bold" Margin="0,0,0,5"
Foreground="{DynamicResource ForegroundBrush}"/>
<PasswordBox x:Name="PasswordBox" Height="25" Margin="0,0,0,15"/>
</StackPanel>
</Border>
<TextBlock Text="Password:" FontWeight="Bold" Margin="0,0,0,5"
Foreground="{DynamicResource ForegroundBrush}"/>
<PasswordBox x:Name="PasswordBox" Height="25" Margin="0,0,0,0"/>
</StackPanel>

<!-- Microsoft Entra MFA Fields -->
<StackPanel x:Name="EntraMfaPanel" Visibility="Collapsed" Margin="0,0,0,15">
<TextBlock Text="Username (optional):" FontWeight="Bold" Margin="0,0,0,5"
Foreground="{DynamicResource ForegroundBrush}"/>
<TextBox x:Name="EntraMfaUsernameBox" Height="25" Margin="0,0,0,0"
ToolTip="Optional: Pre-populate the authentication dialog with this email address"/>
</StackPanel>

<!-- Description -->
<TextBlock Text="Description (optional):" FontWeight="Bold" Margin="0,0,0,5"
Expand Down Expand Up @@ -114,10 +126,15 @@
</StackPanel>
</ScrollViewer>

<!-- Status -->
<TextBlock x:Name="StatusText" Grid.Row="2"
Foreground="{DynamicResource ForegroundMutedBrush}"
TextWrapping="Wrap" Margin="0,8,0,0" Visibility="Collapsed"/>

<!-- Buttons -->
<StackPanel Grid.Row="2" Orientation="Horizontal" HorizontalAlignment="Right" Margin="0,15,0,0">
<Button Content="Test Connection" Width="120" Height="30" Margin="0,0,10,0" Click="TestConnection_Click"/>
<Button Content="Save" Width="80" Height="30" Margin="0,0,10,0" Click="Save_Click" IsDefault="True"/>
<StackPanel Grid.Row="3" Orientation="Horizontal" HorizontalAlignment="Right" Margin="0,15,0,0">
<Button x:Name="TestConnectionButton" Content="Test Connection" Width="120" Height="30" Margin="0,0,10,0" Click="TestConnection_Click"/>
<Button x:Name="SaveButton" Content="Save" Width="80" Height="30" Margin="0,0,10,0" Click="Save_Click" IsDefault="True"/>
<Button Content="Cancel" Width="80" Height="30" Click="Cancel_Click" IsCancel="True"/>
</StackPanel>
</Grid>
Expand Down
Loading
Loading