Skip to content

Fix query store regressions TVF and context menu icons #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
Feb 26, 2026
Merged

Fix query store regressions TVF and context menu icons #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions Dashboard/CollectionLogWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,19 @@
Background="{DynamicResource BackgroundBrush}">
<Window.Resources>
<ContextMenu x:Key="DataGridContextMenu">
<MenuItem Header="Copy Cell" Click="CopyCell_Click"/>
<MenuItem Header="Copy Row" Click="CopyRow_Click"/>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click"/>
<MenuItem Header="Copy Cell" Click="CopyCell_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CB;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy Row" Click="CopyRow_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4C4;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4D1;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click"/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CA;"/></MenuItem.Icon>
</MenuItem>
</ContextMenu>
</Window.Resources>
<Grid>
Expand Down
16 changes: 12 additions & 4 deletions Dashboard/CollectorScheduleWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,19 @@
Background="{DynamicResource BackgroundBrush}">
<Window.Resources>
<ContextMenu x:Key="DataGridContextMenu">
<MenuItem Header="Copy Cell" Click="CopyCell_Click"/>
<MenuItem Header="Copy Row" Click="CopyRow_Click"/>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click"/>
<MenuItem Header="Copy Cell" Click="CopyCell_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CB;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy Row" Click="CopyRow_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4C4;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4D1;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click"/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CA;"/></MenuItem.Icon>
</MenuItem>
</ContextMenu>
</Window.Resources>
<Grid Margin="16">
Expand Down
16 changes: 12 additions & 4 deletions Dashboard/Controls/AlertsHistoryContent.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,19 @@

<!-- Context Menu for DataGrid Copy/Export -->
<ContextMenu x:Key="DataGridContextMenu">
<MenuItem Header="Copy Cell" Click="CopyCell_Click"/>
<MenuItem Header="Copy Row" Click="CopyRow_Click"/>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click"/>
<MenuItem Header="Copy Cell" Click="CopyCell_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CB;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy Row" Click="CopyRow_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4C4;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4D1;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click"/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CA;"/></MenuItem.Icon>
</MenuItem>
</ContextMenu>

<Style x:Key="DefaultRowStyle" TargetType="DataGridRow">
Expand Down
20 changes: 15 additions & 5 deletions Dashboard/MainWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,23 @@
</ListView.ItemTemplate>
<ListView.ContextMenu>
<ContextMenu Opened="ServerContextMenu_Opened">
<MenuItem Header="Open in New Tab" Click="OpenServerTab_Click"/>
<MenuItem Header="Check Connection" Click="CheckConnection_Click"/>
<MenuItem Header="Edit Server..." Click="EditServer_Click"/>
<MenuItem Header="Open in New Tab" Click="OpenServerTab_Click">
<MenuItem.Icon><TextBlock Text="&#x1F5C2;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Check Connection" Click="CheckConnection_Click">
<MenuItem.Icon><TextBlock Text="&#x2705;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Edit Server..." Click="EditServer_Click">
<MenuItem.Icon><TextBlock Text="&#x270F;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem x:Name="ToggleFavoriteMenuItem" Header="Set as Favorite" Click="ToggleFavorite_Click"/>
<MenuItem x:Name="ToggleFavoriteMenuItem" Header="Set as Favorite" Click="ToggleFavorite_Click">
<MenuItem.Icon><TextBlock Text="&#x2B50;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="Remove Server" Click="RemoveServer_Click"/>
<MenuItem Header="Remove Server" Click="RemoveServer_Click">
<MenuItem.Icon><TextBlock Text="&#x1F5D1;"/></MenuItem.Icon>
</MenuItem>
</ContextMenu>
</ListView.ContextMenu>
</ListView>
Expand Down
16 changes: 12 additions & 4 deletions Dashboard/ManageServersWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,19 @@
<Window.Resources>
<BooleanToVisibilityConverter x:Key="BoolToVisibilityConverter"/>
<ContextMenu x:Key="DataGridContextMenu">
<MenuItem Header="Copy Cell" Click="CopyCell_Click"/>
<MenuItem Header="Copy Row" Click="CopyRow_Click"/>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click"/>
<MenuItem Header="Copy Cell" Click="CopyCell_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CB;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy Row" Click="CopyRow_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4C4;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4D1;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click"/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CA;"/></MenuItem.Icon>
</MenuItem>
</ContextMenu>
</Window.Resources>
<Grid Margin="16">
Expand Down
16 changes: 12 additions & 4 deletions Lite/Controls/AlertsHistoryTab.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,19 @@
</ResourceDictionary.MergedDictionaries>

<ContextMenu x:Key="DataGridContextMenu">
<MenuItem Header="Copy Cell" Click="CopyCell_Click"/>
<MenuItem Header="Copy Row" Click="CopyRow_Click"/>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click"/>
<MenuItem Header="Copy Cell" Click="CopyCell_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CB;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy Row" Click="CopyRow_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4C4;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4D1;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click"/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CA;"/></MenuItem.Icon>
</MenuItem>
</ContextMenu>

<Style x:Key="DefaultRowStyle" TargetType="DataGridRow">
Expand Down
28 changes: 21 additions & 7 deletions Lite/Controls/ServerTab.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,29 @@

<!-- Context Menu for DataGrid Copy -->
<ContextMenu x:Key="DataGridContextMenu">
<MenuItem Header="Copy Cell" Click="CopyCell_Click"/>
<MenuItem Header="Copy Row" Click="CopyRow_Click"/>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click"/>
<MenuItem Header="Copy Repro Script" Click="CopyReproScript_Click"/>
<MenuItem Header="Copy Cell" Click="CopyCell_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CB;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy Row" Click="CopyRow_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4C4;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4D1;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy Repro Script" Click="CopyReproScript_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4DD;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click"/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CA;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="View Plan" Click="ViewEstimatedPlan_Click"/>
<MenuItem Header="Get Actual Plan" Click="GetActualPlan_Click"/>
<MenuItem Header="View Plan" Click="ViewEstimatedPlan_Click">
<MenuItem.Icon><TextBlock Text="&#x1F50D;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Get Actual Plan" Click="GetActualPlan_Click">
<MenuItem.Icon><TextBlock Text="&#x25B6;"/></MenuItem.Icon>
</MenuItem>
</ContextMenu>

<Style x:Key="GridRowStyle" TargetType="DataGridRow">
Expand Down
20 changes: 15 additions & 5 deletions Lite/MainWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,23 @@
Background="{DynamicResource BackgroundLightBrush}">
<Border.ContextMenu>
<ContextMenu>
<MenuItem Header="Connect" Click="ServerContextMenu_Connect_Click"/>
<MenuItem Header="Disconnect" Click="ServerContextMenu_Disconnect_Click"/>
<MenuItem Header="Connect" Click="ServerContextMenu_Connect_Click">
<MenuItem.Icon><TextBlock Text="&#x1F517;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Disconnect" Click="ServerContextMenu_Disconnect_Click">
<MenuItem.Icon><TextBlock Text="&#x274C;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="Toggle Favorite" Click="ServerContextMenu_ToggleFavorite_Click"/>
<MenuItem Header="Toggle Favorite" Click="ServerContextMenu_ToggleFavorite_Click">
<MenuItem.Icon><TextBlock Text="&#x2B50;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="Edit..." Click="ServerContextMenu_Edit_Click"/>
<MenuItem Header="Remove" Click="ServerContextMenu_Remove_Click"/>
<MenuItem Header="Edit..." Click="ServerContextMenu_Edit_Click">
<MenuItem.Icon><TextBlock Text="&#x270F;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Remove" Click="ServerContextMenu_Remove_Click">
<MenuItem.Icon><TextBlock Text="&#x1F5D1;"/></MenuItem.Icon>
</MenuItem>
</ContextMenu>
</Border.ContextMenu>
<Grid>
Expand Down
16 changes: 12 additions & 4 deletions Lite/Windows/CollectionLogWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,19 @@
<ResourceDictionary Source="/Themes/DarkTheme.xaml"/>
</ResourceDictionary.MergedDictionaries>
<ContextMenu x:Key="DataGridContextMenu">
<MenuItem Header="Copy Cell" Click="CopyCell_Click"/>
<MenuItem Header="Copy Row" Click="CopyRow_Click"/>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click"/>
<MenuItem Header="Copy Cell" Click="CopyCell_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CB;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy Row" Click="CopyRow_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4C4;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4D1;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click"/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CA;"/></MenuItem.Icon>
</MenuItem>
</ContextMenu>
</ResourceDictionary>
</Window.Resources>
Expand Down
16 changes: 12 additions & 4 deletions Lite/Windows/ManageServersWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,19 @@
<ResourceDictionary Source="/Themes/DarkTheme.xaml"/>
</ResourceDictionary.MergedDictionaries>
<ContextMenu x:Key="DataGridContextMenu">
<MenuItem Header="Copy Cell" Click="CopyCell_Click"/>
<MenuItem Header="Copy Row" Click="CopyRow_Click"/>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click"/>
<MenuItem Header="Copy Cell" Click="CopyCell_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CB;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy Row" Click="CopyRow_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4C4;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4D1;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click"/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CA;"/></MenuItem.Icon>
</MenuItem>
</ContextMenu>
</ResourceDictionary>
</Window.Resources>
Expand Down
16 changes: 12 additions & 4 deletions Lite/Windows/ProcedureHistoryWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,19 @@
<ResourceDictionary Source="/Themes/DarkTheme.xaml"/>
</ResourceDictionary.MergedDictionaries>
<ContextMenu x:Key="DataGridContextMenu">
<MenuItem Header="Copy Cell" Click="CopyCell_Click"/>
<MenuItem Header="Copy Row" Click="CopyRow_Click"/>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click"/>
<MenuItem Header="Copy Cell" Click="CopyCell_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CB;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy Row" Click="CopyRow_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4C4;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4D1;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click"/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CA;"/></MenuItem.Icon>
</MenuItem>
</ContextMenu>
</ResourceDictionary>
</Window.Resources>
Expand Down
16 changes: 12 additions & 4 deletions Lite/Windows/QueryStatsHistoryWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,19 @@
<ResourceDictionary Source="/Themes/DarkTheme.xaml"/>
</ResourceDictionary.MergedDictionaries>
<ContextMenu x:Key="DataGridContextMenu">
<MenuItem Header="Copy Cell" Click="CopyCell_Click"/>
<MenuItem Header="Copy Row" Click="CopyRow_Click"/>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click"/>
<MenuItem Header="Copy Cell" Click="CopyCell_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CB;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy Row" Click="CopyRow_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4C4;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4D1;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click"/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CA;"/></MenuItem.Icon>
</MenuItem>
</ContextMenu>
</ResourceDictionary>
</Window.Resources>
Expand Down
16 changes: 12 additions & 4 deletions Lite/Windows/QueryStoreHistoryWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,19 @@
<ResourceDictionary Source="/Themes/DarkTheme.xaml"/>
</ResourceDictionary.MergedDictionaries>
<ContextMenu x:Key="DataGridContextMenu">
<MenuItem Header="Copy Cell" Click="CopyCell_Click"/>
<MenuItem Header="Copy Row" Click="CopyRow_Click"/>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click"/>
<MenuItem Header="Copy Cell" Click="CopyCell_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CB;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy Row" Click="CopyRow_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4C4;"/></MenuItem.Icon>
</MenuItem>
<MenuItem Header="Copy All Rows" Click="CopyAllRows_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4D1;"/></MenuItem.Icon>
</MenuItem>
<Separator/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click"/>
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click">
<MenuItem.Icon><TextBlock Text="&#x1F4CA;"/></MenuItem.Icon>
</MenuItem>
</ContextMenu>
</ResourceDictionary>
</Window.Resources>
Expand Down
Loading
Loading