Rules 15-24: Pattern precision, threshold tuning, message improvements#356
Merged
Conversation
…ments
Rule 15: Exact OR expansion chain check (Nested Loops → Merge Interval →
TopN Sort → Concatenation → Constant Scans) replaces loose ancestor walks
Rule 16: Raise nested loops thresholds to 100K warn / 1M critical
Rule 17: In actual plans, only warn when Merge Join has logical reads
(worktable was actually used); include read count in message
Rule 22: StartsWith("@") instead of Contains; updated message re: column
statistics and 2019+ deferred compilation
Rule 24: Include columnstore scans in Top Above Scan detection
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StartsWith("@")instead ofContains; updated message about column statistics and 2019+ deferred compilationIsScanOperatorhelper)Test plan
dotnet buildclean (0 errors) for Dashboard and Lite🤖 Generated with Claude Code