Skip to content

Fix OverflowException on wait stats decimal division (Issue #395) #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 2 commits into from
Mar 3, 2026
Merged

Fix OverflowException on wait stats decimal division (Issue #395) #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
363f9b5
Fix OverflowException on wait stats with large decimal values — Issue…
erikdarlingdata Mar 3, 2026
ea694ce
Also fix decimal overflow in NocHealth poison wait avg_ms_per_wait
erikdarlingdata Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dashboard/Services/DatabaseService.NocHealth.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ SELECT TOP (3)
waiting_tasks_count_delta,
avg_ms_per_wait =
CASE WHEN waiting_tasks_count_delta > 0
THEN CAST(wait_time_ms_delta AS decimal(19, 2)) / waiting_tasks_count_delta
THEN CAST(CAST(wait_time_ms_delta AS decimal(19, 2)) / waiting_tasks_count_delta AS decimal(18, 4))
ELSE 0 END
FROM collect.wait_stats
WHERE wait_type IN (N'THREADPOOL', N'RESOURCE_SEMAPHORE', N'RESOURCE_SEMAPHORE_QUERY_COMPILE')
Expand Down
8 changes: 4 additions & 4 deletions Dashboard/Services/DatabaseService.QueryPerformance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2328,7 +2328,7 @@ GROUP BY
)
SELECT
ed.collection_time,
executions_per_second = CAST(ed.total_execution_count AS decimal(19, 4)) / ed.interval_seconds
executions_per_second = CAST(CAST(ed.total_execution_count AS decimal(19, 4)) / ed.interval_seconds AS decimal(18, 4))
FROM exec_deltas AS ed
WHERE ed.interval_seconds > 0
ORDER BY
Expand Down Expand Up @@ -2362,7 +2362,7 @@ GROUP BY
)
SELECT
ed.collection_time,
executions_per_second = CAST(ed.total_execution_count AS decimal(19, 4)) / ed.interval_seconds
executions_per_second = CAST(CAST(ed.total_execution_count AS decimal(19, 4)) / ed.interval_seconds AS decimal(18, 4))
FROM exec_deltas AS ed
WHERE ed.interval_seconds > 0
ORDER BY
Expand Down Expand Up @@ -2747,7 +2747,7 @@ WHERE ws.wait_type LIKE N'LCK%'
wait_time_ms_per_second =
CASE
WHEN ld.interval_seconds > 0
THEN CAST(ld.wait_time_ms_delta AS decimal(19, 4)) / ld.interval_seconds
THEN CAST(CAST(ld.wait_time_ms_delta AS decimal(19, 4)) / ld.interval_seconds AS decimal(18, 4))
ELSE 0
END
FROM lock_deltas AS ld
Expand Down Expand Up @@ -2790,7 +2790,7 @@ WHERE ws.wait_type LIKE N'LCK%'
wait_time_ms_per_second =
CASE
WHEN ld.interval_seconds > 0
THEN CAST(ld.wait_time_ms_delta AS decimal(19, 4)) / ld.interval_seconds
THEN CAST(CAST(ld.wait_time_ms_delta AS decimal(19, 4)) / ld.interval_seconds AS decimal(18, 4))
ELSE 0
END
FROM lock_deltas AS ld
Expand Down
32 changes: 16 additions & 16 deletions Dashboard/Services/DatabaseService.ResourceMetrics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,13 +444,13 @@ AND ws.wait_type IN (SELECT wait_type FROM top_waits)
wait_time_ms_per_second =
CASE
WHEN wd.interval_seconds > 0
THEN CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds
THEN CAST(CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds AS decimal(18, 4))
ELSE 0
END,
signal_wait_time_ms_per_second =
CASE
WHEN wd.interval_seconds > 0
THEN CAST(wd.signal_wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds
THEN CAST(CAST(wd.signal_wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds AS decimal(18, 4))
ELSE 0
END,
wd.waiting_tasks_count
Expand Down Expand Up @@ -521,13 +521,13 @@ AND ws.wait_type IN (SELECT wait_type FROM top_waits)
wait_time_ms_per_second =
CASE
WHEN wd.interval_seconds > 0
THEN CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds
THEN CAST(CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds AS decimal(18, 4))
ELSE 0
END,
signal_wait_time_ms_per_second =
CASE
WHEN wd.interval_seconds > 0
THEN CAST(wd.signal_wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds
THEN CAST(CAST(wd.signal_wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds AS decimal(18, 4))
ELSE 0
END,
wd.waiting_tasks_count
Expand Down Expand Up @@ -1879,19 +1879,19 @@ FROM collect.wait_stats AS ws
wait_time_ms_per_second =
CASE
WHEN wd.interval_seconds > 0
THEN CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds
THEN CAST(CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds AS decimal(18, 4))
ELSE 0
END,
signal_wait_time_ms_per_second =
CASE
WHEN wd.interval_seconds > 0
THEN CAST(wd.signal_wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds
THEN CAST(CAST(wd.signal_wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds AS decimal(18, 4))
ELSE 0
END,
avg_ms_per_wait =
CASE
WHEN wd.waiting_tasks_delta > 0
THEN CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.waiting_tasks_delta
THEN CAST(CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.waiting_tasks_delta AS decimal(18, 4))
ELSE 0
END
FROM wait_deltas AS wd
Expand Down Expand Up @@ -1957,19 +1957,19 @@ FROM collect.wait_stats AS ws
wait_time_ms_per_second =
CASE
WHEN wd.interval_seconds > 0
THEN CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds
THEN CAST(CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds AS decimal(18, 4))
ELSE 0
END,
signal_wait_time_ms_per_second =
CASE
WHEN wd.interval_seconds > 0
THEN CAST(wd.signal_wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds
THEN CAST(CAST(wd.signal_wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds AS decimal(18, 4))
ELSE 0
END,
avg_ms_per_wait =
CASE
WHEN wd.waiting_tasks_delta > 0
THEN CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.waiting_tasks_delta
THEN CAST(CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.waiting_tasks_delta AS decimal(18, 4))
ELSE 0
END
FROM wait_deltas AS wd
Expand Down Expand Up @@ -2066,15 +2066,15 @@ FROM collect.wait_stats AS ws
wd.wait_type,
wait_time_ms_per_second =
CASE WHEN wd.interval_seconds > 0
THEN CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds
THEN CAST(CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds AS decimal(18, 4))
ELSE 0 END,
signal_wait_time_ms_per_second =
CASE WHEN wd.interval_seconds > 0
THEN CAST(wd.signal_wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds
THEN CAST(CAST(wd.signal_wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds AS decimal(18, 4))
ELSE 0 END,
avg_ms_per_wait =
CASE WHEN wd.waiting_tasks_delta > 0
THEN CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.waiting_tasks_delta
THEN CAST(CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.waiting_tasks_delta AS decimal(18, 4))
ELSE 0 END
FROM wait_deltas AS wd
WHERE wd.wait_time_ms_delta > 0
Expand Down Expand Up @@ -2124,15 +2124,15 @@ FROM collect.wait_stats AS ws
wd.wait_type,
wait_time_ms_per_second =
CASE WHEN wd.interval_seconds > 0
THEN CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds
THEN CAST(CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds AS decimal(18, 4))
ELSE 0 END,
signal_wait_time_ms_per_second =
CASE WHEN wd.interval_seconds > 0
THEN CAST(wd.signal_wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds
THEN CAST(CAST(wd.signal_wait_time_ms_delta AS decimal(19, 4)) / wd.interval_seconds AS decimal(18, 4))
ELSE 0 END,
avg_ms_per_wait =
CASE WHEN wd.waiting_tasks_delta > 0
THEN CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.waiting_tasks_delta
THEN CAST(CAST(wd.wait_time_ms_delta AS decimal(19, 4)) / wd.waiting_tasks_delta AS decimal(18, 4))
ELSE 0 END
FROM wait_deltas AS wd
WHERE wd.wait_time_ms_delta > 0
Expand Down
Loading