Skip to content

Fix sp_IndexCleanup column mapping and show all columns#503

Merged
erikdarlingdata merged 1 commit into
devfrom
feature/fix-indexcleanup-columns
Mar 9, 2026
Merged

Fix sp_IndexCleanup column mapping and show all columns#503
erikdarlingdata merged 1 commit into
devfrom
feature/fix-indexcleanup-columns

Conversation

@erikdarlingdata
Copy link
Copy Markdown
Owner

@erikdarlingdata erikdarlingdata commented Mar 9, 2026

Summary

  • Fixed summary grid ordinal mapping — every column after DatabaseName was mapped to the wrong SP column (off by one)
  • Expanded summary grid from 6 to all 29 columns from sp_IndexCleanup's second result set
  • Added Script column (with tooltip) to detail grid — the actual DROP/CREATE INDEX T-SQL
  • Added missing detail columns: AdditionalInfo, SupersededInfo, IndexRows, Definition (Dashboard), TargetIndex (Lite)
  • Applied to both Dashboard and Lite

Test plan

  • Build Dashboard and Lite — 0 warnings, 0 errors
  • Run Index Analysis in Dashboard against sql2022, verify all columns populated correctly
  • Run Index Analysis in Lite against sql2022, verify matching columns
  • Verify Script column tooltip shows full T-SQL on hover
  • Verify right-click copy works on new columns

🤖 Generated with Claude Code

@erikdarlingdata @claude
Fix sp_IndexCleanup column mapping and show all result set columns
ac2116a 
Summary grid was mapping wrong ordinals (off by one after column 1) and only
showed 6 of 29 columns. Detail grid was missing the Script column — the actual
actionable DROP/CREATE INDEX output. Fixed ordinal mapping, expanded both grids
to show all columns from both result sets, added Script and Definition columns
with tooltips. Applied to both Dashboard and Lite.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@erikdarlingdata erikdarlingdata merged commit cd97716 into dev Mar 9, 2026
3 checks passed
@erikdarlingdata erikdarlingdata deleted the feature/fix-indexcleanup-columns branch March 9, 2026 21:37
erikdarlingdata added a commit that referenced this pull request Mar 11, 2026
@erikdarlingdata @claude
Update changelog and README for v2.2.0 release
036afea 
Add missing changelog entries for PRs #503-#518: DuckDB 1.5.0 upgrade,
parquet compaction (13-26x perf improvement), SignPath code signing,
ReadOnlyIntent, status bar used/file size, collector diagnostics,
plan viewer fixes. Update README with code signing note, DuckDB 1.5.0
data storage section, ReadOnlyIntent quick start, expanded FinOps
description. Release date set to 2026-03-11.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@erikdarlingdata erikdarlingdata mentioned this pull request Mar 11, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@erikdarlingdata