Skip to content

Polish Lite chart axes and sub-tab styling #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
Apr 18, 2026
Merged

Polish Lite chart axes and sub-tab styling #862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lite/Controls/CorrelatedTimelineLanesControl.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,11 @@
$"cpuRows={refCpuTask.Result?.Count ?? 0}, waitRows={refWaitTask.Result?.Count ?? 0}");

if (refCpuTask.IsCompletedSuccessfully)
AddGhostLine(CpuChart, refCpuTask.Result

Check warning on line 173 in Lite/Controls/CorrelatedTimelineLanesControl.xaml.cs

View workflow job for this annotation

GitHub Actions / build 

Possible null reference argument for parameter 'source' in 'IEnumerable<(double, double)> Enumerable.Select<CpuUtilizationRow, (double, double)>(IEnumerable<CpuUtilizationRow> source, Func<CpuUtilizationRow, (double, double)> selector)'.
.Select(d => (d.SampleTime.Add(timeShift).ToOADate(), (double)d.SqlServerCpu)).ToList(), "#4FC3F7");

if (refWaitTask.IsCompletedSuccessfully)
AddGhostLine(WaitStatsChart, refWaitTask.Result

Check warning on line 177 in Lite/Controls/CorrelatedTimelineLanesControl.xaml.cs

View workflow job for this annotation

GitHub Actions / build 

Possible null reference argument for parameter 'source' in 'IEnumerable<(double, double WaitTimeMsPerSecond)> Enumerable.Select<WaitStatsTrendPoint, (double, double WaitTimeMsPerSecond)>(IEnumerable<WaitStatsTrendPoint> source, Func<WaitStatsTrendPoint, (double, double WaitTimeMsPerSecond)> selector)'.
.Select(d => (d.CollectionTime.AddMinutes(utcOffset).Add(timeShift).ToOADate(), d.WaitTimeMsPerSecond)).ToList(), "#FFB74D");

if (refBlockingTask.IsCompletedSuccessfully)
Expand Down Expand Up @@ -287,7 +287,7 @@
meanLine.LineWidth = 1;
}

BlockingChart.Plot.Axes.DateTimeTicksBottom();
BlockingChart.Plot.Axes.DateTimeTicksBottomDateChange();
BlockingChart.Plot.Axes.Bottom.TickLabelStyle.IsVisible = false;
ReapplyAxisColors(BlockingChart);

Expand Down Expand Up @@ -363,7 +363,7 @@

_crosshairManager?.SetLaneData(chart, times, values);

chart.Plot.Axes.DateTimeTicksBottom();
chart.Plot.Axes.DateTimeTicksBottomDateChange();
// Hide bottom tick labels on all lanes except the last (File I/O)
if (chart != FileIoChart)
chart.Plot.Axes.Bottom.TickLabelStyle.IsVisible = false;
Expand Down
12 changes: 6 additions & 6 deletions Lite/Controls/ServerTab.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@
<!-- Query Performance Tab -->
<TabItem Header="Queries">
<Grid Margin="8">
<TabControl x:Name="QueriesSubTabControl" Background="Transparent" BorderThickness="0">
<TabControl x:Name="QueriesSubTabControl" Background="Transparent" BorderThickness="0" ItemContainerStyle="{DynamicResource SubTabItemStyle}">
<TabItem Header="Performance Trends">
<Grid>
<Grid.RowDefinitions>
Expand Down Expand Up @@ -1046,7 +1046,7 @@

<!-- Memory Tab -->
<TabItem Header="Memory">
<TabControl x:Name="MemorySubTabControl" Background="Transparent" BorderThickness="0">
<TabControl x:Name="MemorySubTabControl" Background="Transparent" BorderThickness="0" ItemContainerStyle="{DynamicResource SubTabItemStyle}">
<!-- Memory Overview Sub-Tab -->
<TabItem Header="Overview">
<Grid Margin="8">
Expand Down Expand Up @@ -1182,7 +1182,7 @@
<!-- File I/O Tab -->
<TabItem Header="File I/O">
<Grid Margin="8">
<TabControl Background="Transparent" BorderThickness="0">
<TabControl Background="Transparent" BorderThickness="0" ItemContainerStyle="{DynamicResource SubTabItemStyle}">
<!-- File I/O Latency sub-tab -->
<TabItem Header="File I/O Latency">
<Grid>
Expand Down Expand Up @@ -1239,7 +1239,7 @@
<!-- Blocking Tab -->
<TabItem Header="Blocking">
<Grid Margin="8">
<TabControl x:Name="BlockingSubTabControl" Background="Transparent" BorderThickness="0">
<TabControl x:Name="BlockingSubTabControl" Background="Transparent" BorderThickness="0" ItemContainerStyle="{DynamicResource SubTabItemStyle}">
<TabItem Header="Trends">
<Grid>
<Grid.RowDefinitions>
Expand Down Expand Up @@ -1578,7 +1578,7 @@
<!-- Configuration Tab -->
<TabItem Header="Configuration">
<Grid Margin="8">
<TabControl Background="Transparent" BorderThickness="0">
<TabControl Background="Transparent" BorderThickness="0" ItemContainerStyle="{DynamicResource SubTabItemStyle}">
<TabItem Header="Server Configuration">
<DataGrid x:Name="ServerConfigGrid"
AutoGenerateColumns="False" IsReadOnly="True"
Expand Down Expand Up @@ -1802,7 +1802,7 @@
<!-- Collection Health Tab -->
<TabItem Header="Collection Health">
<Grid Margin="8">
<TabControl Background="Transparent" BorderThickness="0">
<TabControl Background="Transparent" BorderThickness="0" ItemContainerStyle="{DynamicResource SubTabItemStyle}">
<TabItem Header="Health Summary">
<DataGrid x:Name="CollectionHealthGrid"
AutoGenerateColumns="False" IsReadOnly="True"
Expand Down
Loading
Loading