Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dashboard/Analysis/SqlServerBaselineProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ private static double PoolVariance(List<BaselineBucket> buckets, double grandMea
return totalSumSq / (totalSamples - 1);
}

private class CachedBaseline
private sealed class CachedBaseline
{
public DateTime ComputedAt { get; init; }
public DateTime RealTime { get; init; }
Expand Down
2 changes: 1 addition & 1 deletion Dashboard/Controls/ConfigChangesContent.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click"/>
</ContextMenu>
</UserControl.Resources>
<TabControl>
<TabControl ItemContainerStyle="{DynamicResource SubTabItemStyle}">
<!-- Server Configuration Changes Sub-Tab -->
<TabItem Header="Server Config Changes">
<Grid>
Expand Down
4 changes: 2 additions & 2 deletions Dashboard/Controls/CorrelatedTimelineLanesControl.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ private void UpdateBlockingLane(List<(double Time, double Value)> blockingData,
}
}

BlockingChart.Plot.Axes.DateTimeTicksBottom();
BlockingChart.Plot.Axes.DateTimeTicksBottomDateChange();
BlockingChart.Plot.Axes.Bottom.TickLabelStyle.IsVisible = false;
TabHelpers.ReapplyAxisColors(BlockingChart);

Expand Down Expand Up @@ -394,7 +394,7 @@ private void UpdateLane(ScottPlot.WPF.WpfPlot chart, string title,

_crosshairManager?.SetLaneData(chart, times, values);

chart.Plot.Axes.DateTimeTicksBottom();
chart.Plot.Axes.DateTimeTicksBottomDateChange();
if (chart != FileIoChart)
chart.Plot.Axes.Bottom.TickLabelStyle.IsVisible = false;

Expand Down
2 changes: 1 addition & 1 deletion Dashboard/Controls/CurrentConfigContent.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<MenuItem Header="Export to CSV..." Click="ExportToCsv_Click"/>
</ContextMenu>
</UserControl.Resources>
<TabControl>
<TabControl ItemContainerStyle="{DynamicResource SubTabItemStyle}">
<!-- Current Server Configuration Sub-Tab -->
<TabItem Header="Server Configuration">
<Grid>
Expand Down
2 changes: 1 addition & 1 deletion Dashboard/Controls/FinOpsContent.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
SelectionChanged="ServerSelector_SelectionChanged"/>
</StackPanel>

<TabControl Grid.Row="1" Background="Transparent" BorderThickness="0">
<TabControl Grid.Row="1" Background="Transparent" BorderThickness="0" ItemContainerStyle="{DynamicResource SubTabItemStyle}">

<!-- Recommendations Sub-Tab -->
<TabItem Header="Recommendations">
Expand Down
2 changes: 1 addition & 1 deletion Dashboard/Controls/MemoryContent.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
</ResourceDictionary>
</UserControl.Resources>

<TabControl x:Name="SubTabControl" TabStripPlacement="Top" Margin="0,5,0,0">
<TabControl x:Name="SubTabControl" TabStripPlacement="Top" Margin="0,5,0,0" ItemContainerStyle="{DynamicResource SubTabItemStyle}">
<!-- Memory Overview Sub-Tab -->
<TabItem Header="Memory Overview">
<!-- Chart + Summary Panel (grid removed) -->
Expand Down
12 changes: 6 additions & 6 deletions Dashboard/Controls/MemoryContent.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ private void LoadMemoryStatsOverviewChart(List<MemoryStatsItem> memoryData, int
noDataText.LabelAlignment = ScottPlot.Alignment.MiddleCenter;
}

MemoryStatsOverviewChart.Plot.Axes.DateTimeTicksBottom();
MemoryStatsOverviewChart.Plot.Axes.DateTimeTicksBottomDateChange();
MemoryStatsOverviewChart.Plot.Axes.SetLimitsX(xMin, xMax);
MemoryStatsOverviewChart.Plot.YLabel("MB");
// Fixed negative space for legend
Expand Down Expand Up @@ -605,7 +605,7 @@ private void LoadMemoryGrantSizingChart(List<PoolGrantPoint> aggregated, int hou
MemoryGrantSizingChart.Plot.Legend.FontSize = 12;
}

MemoryGrantSizingChart.Plot.Axes.DateTimeTicksBottom();
MemoryGrantSizingChart.Plot.Axes.DateTimeTicksBottomDateChange();
MemoryGrantSizingChart.Plot.Axes.SetLimitsX(xMin, xMax);
MemoryGrantSizingChart.Plot.YLabel("MB");
MemoryGrantSizingChart.Plot.Axes.AutoScaleY();
Expand Down Expand Up @@ -675,7 +675,7 @@ private void LoadMemoryGrantActivityChart(List<PoolGrantPoint> aggregated, int h
MemoryGrantActivityChart.Plot.Legend.FontSize = 12;
}

MemoryGrantActivityChart.Plot.Axes.DateTimeTicksBottom();
MemoryGrantActivityChart.Plot.Axes.DateTimeTicksBottomDateChange();
MemoryGrantActivityChart.Plot.Axes.SetLimitsX(xMin, xMax);
MemoryGrantActivityChart.Plot.YLabel("Count");
MemoryGrantActivityChart.Plot.Axes.AutoScaleY();
Expand Down Expand Up @@ -856,7 +856,7 @@ private async System.Threading.Tasks.Task UpdateMemoryClerksChartFromPickerAsync
MemoryClerksTopText.Text = "N/A";
}

MemoryClerksChart.Plot.Axes.DateTimeTicksBottom();
MemoryClerksChart.Plot.Axes.DateTimeTicksBottomDateChange();
MemoryClerksChart.Plot.Axes.SetLimitsX(xMin, xMax);
MemoryClerksChart.Plot.YLabel("MB");
MemoryClerksChart.Plot.Axes.AutoScaleY();
Expand Down Expand Up @@ -1001,7 +1001,7 @@ private void LoadPlanCacheChart(IEnumerable<PlanCacheStatsItem> data, int hoursB
noDataText.LabelAlignment = ScottPlot.Alignment.MiddleCenter;
}

PlanCacheChart.Plot.Axes.DateTimeTicksBottom();
PlanCacheChart.Plot.Axes.DateTimeTicksBottomDateChange();
PlanCacheChart.Plot.Axes.SetLimitsX(xMin, xMax);
PlanCacheChart.Plot.YLabel("MB");
// Fixed negative space for legend
Expand Down Expand Up @@ -1120,7 +1120,7 @@ private void LoadMemoryPressureEventsChart(IEnumerable<MemoryPressureEventItem>
noDataText.LabelAlignment = ScottPlot.Alignment.MiddleCenter;
}

MemoryPressureEventsChart.Plot.Axes.DateTimeTicksBottom();
MemoryPressureEventsChart.Plot.Axes.DateTimeTicksBottomDateChange();
MemoryPressureEventsChart.Plot.Axes.SetLimitsX(xMin, xMax);
MemoryPressureEventsChart.Plot.YLabel("Event Count");
// Fixed negative space for legend
Expand Down
2 changes: 1 addition & 1 deletion Dashboard/Controls/QueryPerformanceContent.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
</ResourceDictionary>
</UserControl.Resources>

<TabControl x:Name="SubTabControl" TabStripPlacement="Top" Margin="0,5,0,0">
<TabControl x:Name="SubTabControl" TabStripPlacement="Top" Margin="0,5,0,0" ItemContainerStyle="{DynamicResource SubTabItemStyle}">
<!-- Performance Trends Sub-Tab -->
<TabItem Header="Performance Trends">
<Grid>
Expand Down
4 changes: 2 additions & 2 deletions Dashboard/Controls/QueryPerformanceContent.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2437,7 +2437,7 @@ private void LoadDurationChart(WpfPlot chart, IEnumerable<DurationTrendItem> tre
_legendPanels[chart] = chart.Plot.ShowLegend(ScottPlot.Edge.Bottom);
chart.Plot.Legend.FontSize = 12;

chart.Plot.Axes.DateTimeTicksBottom();
chart.Plot.Axes.DateTimeTicksBottomDateChange();
chart.Plot.Axes.SetLimitsX(xMin, xMax);
chart.Plot.YLabel("Duration (ms/sec)");
TabHelpers.LockChartVerticalAxis(chart);
Expand Down Expand Up @@ -2492,7 +2492,7 @@ private void LoadExecChart(IEnumerable<ExecutionTrendItem> execTrends, int hours
_legendPanels[QueryPerfTrendsExecChart] = QueryPerfTrendsExecChart.Plot.ShowLegend(ScottPlot.Edge.Bottom);
QueryPerfTrendsExecChart.Plot.Legend.FontSize = 12;

QueryPerfTrendsExecChart.Plot.Axes.DateTimeTicksBottom();
QueryPerfTrendsExecChart.Plot.Axes.DateTimeTicksBottomDateChange();
QueryPerfTrendsExecChart.Plot.Axes.SetLimitsX(xMin, xMax);
QueryPerfTrendsExecChart.Plot.YLabel("Executions/sec");
TabHelpers.LockChartVerticalAxis(QueryPerfTrendsExecChart);
Expand Down
4 changes: 2 additions & 2 deletions Dashboard/Controls/ResourceMetricsContent.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
</ContextMenu>
</UserControl.Resources>

<TabControl x:Name="SubTabControl" TabStripPlacement="Top" Margin="0,5,0,0">
<TabControl x:Name="SubTabControl" TabStripPlacement="Top" Margin="0,5,0,0" ItemContainerStyle="{DynamicResource SubTabItemStyle}">
<!-- Server Trends Sub-Tab — Correlated Timeline Lanes -->
<TabItem Header="Server Trends">
<DockPanel>
Expand Down Expand Up @@ -148,7 +148,7 @@

<!-- File I/O Sub-Tab -->
<TabItem Header="File I/O">
<TabControl Background="Transparent" BorderThickness="0">
<TabControl Background="Transparent" BorderThickness="0" ItemContainerStyle="{DynamicResource SubTabItemStyle}">
<!-- File I/O Latency sub-tab -->
<TabItem Header="File I/O Latency">
<Grid Margin="5">
Expand Down
16 changes: 8 additions & 8 deletions Dashboard/Controls/ResourceMetricsContent.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ private void LoadLatchStatsChart(IEnumerable<LatchStatsItem> data, int hoursBack
noDataText.LabelAlignment = ScottPlot.Alignment.MiddleCenter;
}

LatchStatsChart.Plot.Axes.DateTimeTicksBottom();
LatchStatsChart.Plot.Axes.DateTimeTicksBottomDateChange();
LatchStatsChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(LatchStatsChart);
LatchStatsChart.Plot.YLabel("Wait Time (ms/sec)");
Expand Down Expand Up @@ -495,7 +495,7 @@ private void LoadSpinlockStatsChart(IEnumerable<SpinlockStatsItem> data, int hou
noDataText.LabelAlignment = ScottPlot.Alignment.MiddleCenter;
}

SpinlockStatsChart.Plot.Axes.DateTimeTicksBottom();
SpinlockStatsChart.Plot.Axes.DateTimeTicksBottomDateChange();
SpinlockStatsChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(SpinlockStatsChart);
SpinlockStatsChart.Plot.YLabel("Collisions/sec");
Expand Down Expand Up @@ -603,7 +603,7 @@ private void LoadCombinedTempDbLatencyChart(List<FileIoLatencyTimeSeriesItem> da
noDataText.LabelAlignment = ScottPlot.Alignment.MiddleCenter;
}

TempDbLatencyChart.Plot.Axes.DateTimeTicksBottom();
TempDbLatencyChart.Plot.Axes.DateTimeTicksBottomDateChange();
TempDbLatencyChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(TempDbLatencyChart);
TempDbLatencyChart.Plot.YLabel("Latency (ms)");
Expand Down Expand Up @@ -708,7 +708,7 @@ private void LoadTempdbStatsChart(IEnumerable<TempdbStatsItem> data, int hoursBa
noDataText.LabelAlignment = ScottPlot.Alignment.MiddleCenter;
}

TempdbStatsChart.Plot.Axes.DateTimeTicksBottom();
TempdbStatsChart.Plot.Axes.DateTimeTicksBottomDateChange();
TempdbStatsChart.Plot.Axes.SetLimitsX(xMin, xMax);
TempdbStatsChart.Plot.Axes.AutoScaleY();
TempdbStatsChart.Plot.YLabel("MB");
Expand Down Expand Up @@ -879,7 +879,7 @@ private void LoadSessionStatsChart(IEnumerable<SessionStatsItem> data, int hours
noDataText.LabelAlignment = ScottPlot.Alignment.MiddleCenter;
}

SessionStatsChart.Plot.Axes.DateTimeTicksBottom();
SessionStatsChart.Plot.Axes.DateTimeTicksBottomDateChange();
SessionStatsChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(SessionStatsChart);
SessionStatsChart.Plot.YLabel("Session Count");
Expand Down Expand Up @@ -1014,7 +1014,7 @@ private void LoadFileIoChart(ScottPlot.WPF.WpfPlot chart, List<FileIoLatencyTime
noDataText.LabelAlignment = ScottPlot.Alignment.MiddleCenter;
}

chart.Plot.Axes.DateTimeTicksBottom();
chart.Plot.Axes.DateTimeTicksBottomDateChange();
chart.Plot.Axes.SetLimitsX(xMin, xMax);
chart.Plot.YLabel(yLabel);
TabHelpers.LockChartVerticalAxis(chart);
Expand Down Expand Up @@ -1485,7 +1485,7 @@ private void LoadPerfmonCountersChart(List<PerfmonStatsItem>? data, int hoursBac
noDataText.LabelAlignment = ScottPlot.Alignment.MiddleCenter;
}

PerfmonCountersChart.Plot.Axes.DateTimeTicksBottom();
PerfmonCountersChart.Plot.Axes.DateTimeTicksBottomDateChange();
PerfmonCountersChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(PerfmonCountersChart);
PerfmonCountersChart.Plot.YLabel("Value/sec");
Expand Down Expand Up @@ -1816,7 +1816,7 @@ private void LoadWaitStatsDetailChart(List<WaitStatsDataPoint>? data, int hoursB
noDataText.LabelAlignment = ScottPlot.Alignment.MiddleCenter;
}

WaitStatsDetailChart.Plot.Axes.DateTimeTicksBottom();
WaitStatsDetailChart.Plot.Axes.DateTimeTicksBottomDateChange();
WaitStatsDetailChart.Plot.Axes.SetLimitsX(xMin, xMax);
TabHelpers.SetChartYLimitsWithLegendPadding(WaitStatsDetailChart);
WaitStatsDetailChart.Plot.YLabel(useAvgPerWait ? "Avg Wait Time (ms/wait)" : "Wait Time (ms/sec)");
Expand Down
2 changes: 1 addition & 1 deletion Dashboard/Controls/SystemEventsContent.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
</ResourceDictionary>
</UserControl.Resources>

<TabControl x:Name="SubTabControl" TabStripPlacement="Top" Margin="0,5,0,0">
<TabControl x:Name="SubTabControl" TabStripPlacement="Top" Margin="0,5,0,0" ItemContainerStyle="{DynamicResource SubTabItemStyle}">
<!-- Overview Tab -->
<TabItem Header="Corruption Events">
<Grid Margin="10,5,10,10">
Expand Down
Loading
Loading