Don't treat transient lock failures as a storage-version mismatch (#977)#983
Merged
Merged
Conversation
DuckDbInitializer.IsStorageVersionError matched "unable to open database"
and "serialization error" — generic DuckDB open failures that also occur
on transient lock contention or a WAL recovering from an unclean shutdown.
When Lite is killed abruptly (e.g. an idle VM logging the user off), the
next launch could match that predicate and run MigrateViaParquetAsync,
which moves the live monitor.duckdb aside and starts with empty tables —
surfacing as "lost all historical data" after an upgrade.
- Narrow IsStorageVersionError to genuine incompatible-format signals
("failed to deserialize", "trying to read a database file with version",
"storage version") only.
- Add IsTransientLockError and retry the open up to 5 times for lock
contention (a just-killed prior instance, antivirus) instead of rebuilding.
- Any other open failure now propagates instead of silently triggering the
destructive Parquet rebuild.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the data-loss half of #977.
DuckDbInitializer.IsStorageVersionErrormatched generic DuckDB open failures ("unable to open database","serialization error") that also occur on transient lock contention and on a WAL recovering from an unclean shutdown. When Lite is killed abruptly — e.g. an idle VM logging the user off — the next launch could match that predicate and runMigrateViaParquetAsync, which moves the livemonitor.duckdbaside and starts with empty tables. To the user this looks like "lost all historical data" after an upgrade.Changes
IsStorageVersionErrorto genuine incompatible-format signals only ("failed to deserialize","trying to read a database file with version","storage version").IsTransientLockErrorandOpenDatabaseAsync, which retries the open up to 5 times for lock contention (a just-killed prior instance, antivirus) instead of rebuilding.Test plan
dotnet build Lite/PerformanceMonitorLite.csproj -c Debug— clean (0 warnings, 0 errors)🤖 Generated with Claude Code