Skip to content

Skip ring-buffer records missing SystemHealth values in CPU collector (#989) #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
May 22, 2026
+31 −12
Merged

Skip ring-buffer records missing SystemHealth values in CPU collector (#989) #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions Lite/Services/RemoteCollectorService.Cpu.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,12 @@ drs.end_time DESC

SELECT TOP (60)
sample_time = DATEADD(SECOND, -((@ms_ticks - t.timestamp) / 1000), SYSDATETIME()),
sqlserver_cpu_utilization = t.record.value('(Record/SchedulerMonitorEvent/SystemHealth/ProcessUtilization)[1]', 'integer'),
sqlserver_cpu_utilization = x.process_utilization,
other_process_cpu_utilization =
CASE
WHEN (100 - t.record.value('(Record/SchedulerMonitorEvent/SystemHealth/SystemIdle)[1]', 'integer')
- t.record.value('(Record/SchedulerMonitorEvent/SystemHealth/ProcessUtilization)[1]', 'integer')) < 0
WHEN (100 - x.system_idle - x.process_utilization) < 0
THEN 0
ELSE 100 - t.record.value('(Record/SchedulerMonitorEvent/SystemHealth/SystemIdle)[1]', 'integer')
- t.record.value('(Record/SchedulerMonitorEvent/SystemHealth/ProcessUtilization)[1]', 'integer')
ELSE 100 - x.system_idle - x.process_utilization
END
FROM
(
Expand All @@ -75,6 +73,16 @@ record = CONVERT(xml, dorb.record)
FROM sys.dm_os_ring_buffers AS dorb
WHERE dorb.ring_buffer_type = N'RING_BUFFER_SCHEDULER_MONITOR'
) AS t
CROSS APPLY
(
SELECT
process_utilization = t.record.value('(Record/SchedulerMonitorEvent/SystemHealth/ProcessUtilization)[1]', 'integer'),
system_idle = t.record.value('(Record/SchedulerMonitorEvent/SystemHealth/SystemIdle)[1]', 'integer')
) AS x
/* Skip ring-buffer records lacking a complete SystemHealth block — their
XML values extract as NULL and would store NULL samples (Issue #989). */
WHERE x.process_utilization IS NOT NULL
AND x.system_idle IS NOT NULL
ORDER BY t.timestamp DESC
OPTION(RECOMPILE);";

Expand Down
25 changes: 18 additions & 7 deletions install/18_collect_cpu_utilization_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,16 +131,12 @@ BEGIN
@start_time
),
sqlserver_cpu_utilization =
t.record.value('(Record/SchedulerMonitorEvent/SystemHealth/ProcessUtilization)[1]', 'integer'),
x.process_utilization,
other_process_cpu_utilization =
CASE
WHEN (100 -
t.record.value('(Record/SchedulerMonitorEvent/SystemHealth/SystemIdle)[1]', 'integer') -
t.record.value('(Record/SchedulerMonitorEvent/SystemHealth/ProcessUtilization)[1]', 'integer')) < 0
WHEN (100 - x.system_idle - x.process_utilization) < 0
THEN 0
ELSE 100 -
t.record.value('(Record/SchedulerMonitorEvent/SystemHealth/SystemIdle)[1]', 'integer') -
t.record.value('(Record/SchedulerMonitorEvent/SystemHealth/ProcessUtilization)[1]', 'integer')
ELSE 100 - x.system_idle - x.process_utilization
END
FROM
(
Expand All @@ -151,12 +147,27 @@ BEGIN
FROM sys.dm_os_ring_buffers AS dorb
WHERE dorb.ring_buffer_type = N'RING_BUFFER_SCHEDULER_MONITOR'
) AS t
CROSS APPLY
(
SELECT
process_utilization =
t.record.value('(Record/SchedulerMonitorEvent/SystemHealth/ProcessUtilization)[1]', 'integer'),
system_idle =
t.record.value('(Record/SchedulerMonitorEvent/SystemHealth/SystemIdle)[1]', 'integer')
) AS x
WHERE DATEADD
(
SECOND,
-((@current_ms_ticks - t.timestamp) / 1000),
@start_time
) > ISNULL(@max_sample_time, DATEADD(DAY, -7, @start_time))
/*
Skip ring-buffer records that lack a complete SystemHealth block —
their XML values extract as NULL and would fail the NOT NULL INSERT,
breaking collection until the bad records age out (Issue #989).
*/
AND x.process_utilization IS NOT NULL
AND x.system_idle IS NOT NULL
ORDER BY
t.timestamp DESC
OPTION(RECOMPILE);
Expand Down
Loading