Continue styling Advice for Humans window

[erikdarlingdata]

Context

PR #47 added initial syntax highlighting to the Advice for Humans window — section headers, warning severities, CREATE INDEX blocks, key-value labels, and SNIFFING markers are now color-coded.

Completed

• ✓ 1. Triage Summary Card
• ✓ 2. Expensive Operator Bars
• ✓ 3. Typography & Spacing
• ✓ 4. Memory Grant — Contextual Color
• ✓ 7. Wait Stats — Proportional Bars
• ✓ 11. Triage Card Headline Hierarchy
• ✓ 12. CPU Bars Disconnected (resolved by [BUG] Query Store Grid doesn't allow horizontal scroll #14)
• ✓ 14. Operator + Timing Visual Grouping
• ✓ 15. Consistent Left Margins
• ✓ 16. Elapsed Time Visibility
• ✓ 17. Missing Index Impact Color

[erikdarlingdata]

Screenshot Review Findings (2026-03-09)

After implementing items #1-#3 and reviewing the live window, here are additional refinements identified:

11. Triage Card Headline Hierarchy

All triage card items are 12px regular weight — the most important finding (e.g., "27% parallel efficiency") blends with less urgent items. The first/most critical line should be slightly larger or bolder to establish a headline.

12. CPU Bars Disconnected from Operators

The amber bar renders on a separate line below the timing text (separate StackPanel child). Visually reads as two elements. Consider putting the bar inline next to the percentage, or grouping them on the same horizontal line.

13. Warning Blocks Are Text-Dense

Multi-line warnings using \x1F-split produce wall-of-text blocks with bullets, predicates, and detail lines. Consider collapsible detail or capping visible lines with "show more."

14. No Visual Grouping Between Operator and Timing

CreateOperatorLine and CreateOperatorTimingLine are separate panel children. With 5+ operators, it's hard to tell which timing belongs to which. A subtle background container or consistent indentation grouping would help.

15. Inconsistent Left Margins

Sub-section labels: Margin(0, 6, 0, 4), warnings: Margin(4, 4, 0, 4), operators: Margin(8, 2, 0, 0). Varying left margins create a ragged left edge that hurts scannability. Standardize the indent levels.

16. Elapsed Time Too Muted

Elapsed timing uses MutedBrush (#8B8FA0) while CPU uses ValueBrush (#E4E6EB). Both are important — consider keeping both in ValueBrush and differentiating with labels instead of brightness.

17. Missing Index Priority Signal

All missing indexes look identical. If MissingIndexResult has impact data, surface it (e.g., "Impact: 85%") to help users prioritize which indexes to create first.