Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/PlanViewer.App/Controls/QuerySessionControl.axaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ private async Task ShowConnectionDialogAsync()

await PopulateDatabases();
await FetchServerMetadataAsync();
await FetchServerUtcOffset();

if (_selectedDatabase != null)
{
Expand Down Expand Up @@ -439,6 +440,22 @@ private async Task FetchServerMetadataAsync()
}
}

private async Task FetchServerUtcOffset()
{
if (_connectionString == null) return;
try
{
await using var conn = new SqlConnection(_connectionString);
await conn.OpenAsync();
await using var cmd = new SqlCommand(
"SELECT DATEDIFF(MINUTE, GETUTCDATE(), GETDATE())", conn);
var offset = await cmd.ExecuteScalarAsync();
if (offset is int mins)
PlanViewer.Core.Services.TimeDisplayHelper.ServerUtcOffsetMinutes = mins;
}
catch { }
}

private async Task FetchDatabaseMetadataAsync()
{
if (_connectionString == null || _serverMetadata == null) return;
Expand Down
9 changes: 9 additions & 0 deletions src/PlanViewer.App/Controls/QueryStoreGridControl.axaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,15 @@
Watermark="0x1AB2C3, dbo.MyProc"
KeyDown="SearchValue_KeyDown"/>
</StackPanel>
<StackPanel Spacing="4">
<TextBlock Text="Time display" Foreground="{DynamicResource ForegroundBrush}" FontSize="11"/>
<ComboBox x:Name="TimeDisplayBox" Width="100" Height="36" FontSize="13"
SelectedIndex="0" SelectionChanged="TimeDisplay_SelectionChanged">
<ComboBoxItem Content="Local" Tag="Local"/>
<ComboBoxItem Content="UTC" Tag="Utc"/>
<ComboBoxItem Content="Server" Tag="Server"/>
</ComboBox>
</StackPanel>
<StackPanel Spacing="2" VerticalAlignment="Center">
<Button x:Name="FetchButton" Content="Fetch" Click="Fetch_Click"
Height="28" Padding="16,0" FontSize="12"
Expand Down
28 changes: 27 additions & 1 deletion src/PlanViewer.App/Controls/QueryStoreGridControl.axaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,29 @@ private async void OrderBy_SelectionChanged(object? sender, SelectionChangedEven
}
}

private void TimeDisplay_SelectionChanged(object? sender, SelectionChangedEventArgs e)
{
if (!IsInitialized) return;
var tag = (TimeDisplayBox.SelectedItem as ComboBoxItem)?.Tag?.ToString();
if (tag == null) return;
TimeDisplayHelper.Current = tag switch
{
"Utc" => TimeDisplayMode.Utc,
"Server" => TimeDisplayMode.Server,
_ => TimeDisplayMode.Local
};
// Refresh grid display
if (_filteredRows.Count > 0)
{
foreach (var row in _filteredRows)
row.NotifyTimeDisplayChanged();
ResultsGrid.ItemsSource = null;
ResultsGrid.ItemsSource = _filteredRows;
}
// Refresh slicer labels
TimeRangeSlicer.Redraw();
}

private void ClearSearch_Click(object? sender, RoutedEventArgs e)
{
SearchTypeBox.SelectedIndex = 0;
Expand Down Expand Up @@ -943,7 +966,10 @@ public void SetBar(string columnId, double ratio, bool isSorted)
public long TotalMemSort => Plan.TotalMemoryGrantPages;
public double AvgMemSort => Plan.AvgMemoryGrantPages;

public string LastExecutedLocal => Plan.LastExecutedUtc.ToLocalTime().ToString("yyyy-MM-dd HH:mm");
public string LastExecutedLocal => TimeDisplayHelper.FormatForDisplay(Plan.LastExecutedUtc);

public void NotifyTimeDisplayChanged() => OnPropertyChanged(nameof(LastExecutedLocal));

public string QueryPreview => Plan.QueryText.Length > 80
? Plan.QueryText[..80].Replace("\n", " ").Replace("\r", "") + "..."
: Plan.QueryText.Replace("\n", " ").Replace("\r", "");
Expand Down
9 changes: 5 additions & 4 deletions src/PlanViewer.App/Controls/TimeRangeSlicerControl.axaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
using Avalonia.Interactivity;
using Avalonia.Media;
using PlanViewer.Core.Models;
using PlanViewer.Core.Services;

namespace PlanViewer.App.Controls;

Expand Down Expand Up @@ -167,7 +168,7 @@ private string GetMetricLabel()

// ── Drawing ────────────────────────────────────────────────────────────

private void Redraw()
public void Redraw()
{
SlicerCanvas.Children.Clear();
if (_data.Count < 2) return;
Expand Down Expand Up @@ -238,7 +239,7 @@ private void Redraw()
for (int i = 0; i < n; i += labelInterval)
{
var x = i * stepX + stepX / 2;
var dt = _data[i].IntervalStartUtc.ToLocalTime();
var dt = TimeDisplayHelper.ConvertForDisplay(_data[i].IntervalStartUtc);
var label = dt.ToString("MM/dd HH:mm");
var tb = new TextBlock
{
Expand Down Expand Up @@ -531,8 +532,8 @@ private void UpdateRangeLabel()
RangeLabel.Text = "";
return;
}
var start = GetDateTimeAtNorm(_rangeStart).ToLocalTime();
var end = GetDateTimeAtNorm(_rangeEnd).ToLocalTime();
var start = TimeDisplayHelper.ConvertForDisplay(GetDateTimeAtNorm(_rangeStart));
var end = TimeDisplayHelper.ConvertForDisplay(GetDateTimeAtNorm(_rangeEnd));
var span = end - start;
RangeLabel.Text = $"{start:yyyy-MM-dd HH:mm} → {end:yyyy-MM-dd HH:mm} ({span.TotalHours:F0}h)";
}
Expand Down
6 changes: 3 additions & 3 deletions src/PlanViewer.App/Dialogs/QueryStoreHistoryWindow.axaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ private async System.Threading.Tasks.Task LoadHistoryAsync()
{
var planCount = _historyData.Select(r => r.PlanId).Distinct().Count();
var totalExec = _historyData.Sum(r => r.CountExecutions);
var first = _historyData.Min(r => r.IntervalStartUtc).ToLocalTime();
var last = _historyData.Max(r => r.IntervalStartUtc).ToLocalTime();
var first = TimeDisplayHelper.ConvertForDisplay(_historyData.Min(r => r.IntervalStartUtc));
var last = TimeDisplayHelper.ConvertForDisplay(_historyData.Max(r => r.IntervalStartUtc));
StatusText.Text = $"{_historyData.Count} intervals, {planCount} plan(s), " +
$"{totalExec:N0} total executions | " +
$"{first:MM/dd HH:mm} to {last:MM/dd HH:mm}";
Expand Down Expand Up @@ -158,7 +158,7 @@ private void UpdateChart()
foreach (var group in planGroups)
{
var ordered = group.OrderBy(r => r.IntervalStartUtc).ToList();
var xs = ordered.Select(r => r.IntervalStartUtc.ToLocalTime().ToOADate()).ToArray();
var xs = ordered.Select(r => TimeDisplayHelper.ConvertForDisplay(r.IntervalStartUtc).ToOADate()).ToArray();
var ys = ordered.Select(r => GetMetricValue(r, tag)).ToArray();

var scatter = HistoryChart.Plot.Add.Scatter(xs, ys);
Expand Down
5 changes: 3 additions & 2 deletions src/PlanViewer.Core/Models/QueryStoreHistoryRow.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using PlanViewer.Core.Services;

namespace PlanViewer.Core.Models;

Expand Down Expand Up @@ -27,6 +28,6 @@ public class QueryStoreHistoryRow
public int MaxDop { get; set; }
public DateTime? LastExecutionUtc { get; set; }

public string IntervalStartLocal => IntervalStartUtc.ToLocalTime().ToString("yyyy-MM-dd HH:mm");
public string LastExecutionLocal => LastExecutionUtc?.ToLocalTime().ToString("yyyy-MM-dd HH:mm") ?? "";
public string IntervalStartLocal => TimeDisplayHelper.FormatForDisplay(IntervalStartUtc);
public string LastExecutionLocal => LastExecutionUtc.HasValue ? TimeDisplayHelper.FormatForDisplay(LastExecutionUtc.Value) : "";
}
10 changes: 6 additions & 4 deletions src/PlanViewer.Core/Services/QueryStoreService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ public static async Task<List<QueryStorePlan>> FetchTopPlansAsync(
}
else
{
timeWhereClause = $"WHERE rs.last_execution_time >= DATEADD(HOUR, -{hoursBack}, GETUTCDATE())";
timeWhereClause = "WHERE rs.last_execution_time >= DATEADD(HOUR, -@hoursBack, GETUTCDATE())";
parameters.Add(new SqlParameter("@hoursBack", hoursBack));
}

// 1. plan_agg: aggregate runtime_stats by plan_id only (cheapest grouping,
Expand Down Expand Up @@ -374,7 +375,7 @@ public static async Task<List<QueryStoreTimeSlice>> FetchTimeSliceDataAsync(
int daysBack = 30,
CancellationToken ct = default)
{
var sql = $@"
var sql = @"
SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;

SELECT
Expand All @@ -389,8 +390,8 @@ public static async Task<List<QueryStoreTimeSlice>> FetchTimeSliceDataAsync(
FROM sys.query_store_runtime_stats rs
JOIN sys.query_store_runtime_stats_interval rsi
ON rs.runtime_stats_interval_id = rsi.runtime_stats_interval_id
WHERE rsi.start_time >= DATEADD(DAY, -{daysBack}, GETUTCDATE())
AND rs.first_execution_time >= DATEADD(DAY, -{daysBack}, GETUTCDATE()) --performance: filter runtime_stats directly
WHERE rsi.start_time >= DATEADD(DAY, -@daysBack, GETUTCDATE())
AND rs.first_execution_time >= DATEADD(DAY, -@daysBack, GETUTCDATE()) --performance: filter runtime_stats directly
GROUP BY DATEADD(HOUR, DATEDIFF(HOUR, 0, rsi.start_time), 0)
ORDER BY bucket_hour DESC;";

Expand All @@ -399,6 +400,7 @@ GROUP BY DATEADD(HOUR, DATEDIFF(HOUR, 0, rsi.start_time), 0)
await using var conn = new SqlConnection(connectionString);
await conn.OpenAsync(ct);
await using var cmd = new SqlCommand(sql, conn) { CommandTimeout = 120 };
cmd.Parameters.Add(new SqlParameter("@daysBack", daysBack));
await using var reader = await cmd.ExecuteReaderAsync(ct);

while (await reader.ReadAsync(ct))
Expand Down
45 changes: 45 additions & 0 deletions src/PlanViewer.Core/Services/TimeDisplayHelper.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
using System;

namespace PlanViewer.Core.Services;

public enum TimeDisplayMode
{
Local,
Utc,
Server
}

public static class TimeDisplayHelper
{
public static TimeDisplayMode Current { get; set; } = TimeDisplayMode.Local;

/// <summary>
/// Offset in minutes from UTC to the connected SQL Server's local time.
/// Set after connecting to a server.
/// </summary>
public static int ServerUtcOffsetMinutes { get; set; }

public static DateTime ConvertForDisplay(DateTime utcTime)
{
return Current switch
{
TimeDisplayMode.Local => utcTime.ToLocalTime(),
TimeDisplayMode.Utc => DateTime.SpecifyKind(utcTime, DateTimeKind.Utc),
TimeDisplayMode.Server => utcTime.AddMinutes(ServerUtcOffsetMinutes),
_ => utcTime.ToLocalTime()
};
}

public static string FormatForDisplay(DateTime utcTime, string format = "yyyy-MM-dd HH:mm")
{
return ConvertForDisplay(utcTime).ToString(format);
}

public static string Suffix => Current switch
{
TimeDisplayMode.Local => "",
TimeDisplayMode.Utc => " (UTC)",
TimeDisplayMode.Server => " (Server)",
_ => ""
};
}
Loading