Skip to content

Add connection toolbar to plan viewer#171

Merged
erikdarlingdata merged 1 commit into
devfrom
feature/plan-viewer-connection-toolbar
Apr 6, 2026
Merged

Add connection toolbar to plan viewer#171
erikdarlingdata merged 1 commit into
devfrom
feature/plan-viewer-connection-toolbar

Conversation

@erikdarlingdata
Copy link
Copy Markdown
Owner

Summary

  • Plan viewer toolbar now has Connect button + server status + database dropdown
  • Enables schema lookups on plans opened from file (no prior connection)
  • Plans from connected sessions inherit the connection automatically
  • Database switching updates the connection context for schema lookups

Closes #166.

Test plan

  • File mode: open .sqlplan → Connect → schema lookup works on operator right-click
  • Editor mode: plans show inherited connection (green server name + database)
  • Database switch → schema lookups use new database context
  • Wrong database → "No indexes found" / "No columns found" (expected)
  • 64 tests pass

🤖 Generated with Claude Code

Plan viewer now has Connect button + server status + database dropdown
in the toolbar, enabling schema lookups on plans opened from file.
Plans loaded from connected sessions inherit the connection and show
the server name and database pre-populated.

- Connect button shows connection dialog, populates database dropdown
- Database switching updates the connection string for schema lookups
- Connection services passed to PlanViewerControl from both MainWindow
  and QuerySessionControl
- Schema lookup items disabled when no connection, enabled after connect

Closes #166.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@erikdarlingdata erikdarlingdata merged commit b9622e7 into dev Apr 6, 2026
2 checks passed
@erikdarlingdata erikdarlingdata deleted the feature/plan-viewer-connection-toolbar branch April 9, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant