Remove unnecessary query_store_query_text joins in grouped fetches#221
Merged
Conversation
… grouped fetches The Step 3 ranked CTEs in both FetchGroupedByQueryHashAsync and FetchGroupedByModuleAsync joined sys.query_store_query_text without using any of its columns — the actual text fetch happens in the Final select. Also fixes tab/space inconsistency in the doc comment blocks for both methods. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Thanks @erikdarlingdata! |
Owner
Author
|
@rferraton no problem! It's a good idea as usual. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JOIN sys.query_store_query_textfrom Step 3 ranked CTEs in bothFetchGroupedByQueryHashAsyncandFetchGroupedByModuleAsync— the text is already fetched in the Final selectqt.query_text_id→q.query_text_idin Module Step 3 (column is onsys.query_store_query, no need for the text table)Follow-up cleanup to PR #218.
Test plan
dotnet buildsucceeds with zero errors (warnings are pre-existing)🤖 Generated with Claude Code